Giter Site home page Giter Site logo

Comments (3)

hannobraun avatar hannobraun commented on July 17, 2024

I just had this thought regarding this issue:
The current test suite covers the basics, assuming that anything not explicitely covered will work fine, since we don't do anything fance that's specific to the type of event. Before implementing this issue, we should have a full test suite in place that covers all types of events, to make sure all our assumptions are correct.

Extending the test suite in such a way would be a good idea anyway, but it would be especially important before we hardcode any assumptions about how the event mask is structured.

from inotify-rs.

hannobraun avatar hannobraun commented on July 17, 2024

Another tought:
I think it would be better to model event queue overflows as an error, not just another kind of event.

from inotify-rs.

hannobraun avatar hannobraun commented on July 17, 2024

Additional thoughts:

  • The cookie could be removed. Instead it could be added as a field to the rename event variants of the EventKind enum. Then an Eq implementation or a dedicated method could be used to determine whether the rename events match.
  • IN_IGNORED events could be made more explicit. Right now they're just another kind of event.

from inotify-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.