Comments (3)
I just had this thought regarding this issue:
The current test suite covers the basics, assuming that anything not explicitely covered will work fine, since we don't do anything fance that's specific to the type of event. Before implementing this issue, we should have a full test suite in place that covers all types of events, to make sure all our assumptions are correct.
Extending the test suite in such a way would be a good idea anyway, but it would be especially important before we hardcode any assumptions about how the event mask is structured.
from inotify-rs.
Another tought:
I think it would be better to model event queue overflows as an error, not just another kind of event.
from inotify-rs.
Additional thoughts:
- The
cookie
could be removed. Instead it could be added as a field to the rename event variants of theEventKind
enum. Then anEq
implementation or a dedicated method could be used to determine whether the rename events match. IN_IGNORED
events could be made more explicit. Right now they're just another kind of event.
from inotify-rs.
Related Issues (20)
- Inotify stream API doesn't seem to work well when watching a file directly. HOT 2
- Consider reverting #146 at some point HOT 3
- Update MSRV to 1.47
- Unsoudness: reference misalignement HOT 2
- Inotify::read_events does not read all events
- EventStream not working HOT 1
- Version not updated in README HOT 1
- panic when call event_stream HOT 1
- Cutting a release for #171 and #173 HOT 1
- Consider addressing buffer alignment in a more robust way HOT 2
- `Inotify::event_stream` is error-prone HOT 2
- Add separate API for adding/removing watches
- Implement ToOwned for `Event<&'a OsStr>` HOT 9
- Consider using cargo clippy in test workflows HOT 1
- Consider increasing the buffer size for the stream example HOT 2
- Using Inotify::read_events in async context HOT 3
- Is it possible to get full path from Event? HOT 3
- Update minimum supported Rust version HOT 1
- duplicate event reports HOT 9
- Async runtime agnostic. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inotify-rs.