Giter Site home page Giter Site logo

Comments (6)

HanSolo avatar HanSolo commented on September 28, 2024

You are right, I will add setters for the grid lines. It was on purpose to not have CSS support because this will make the code more complex and has performance issues, sorry.

from tilesfx.

matthjes avatar matthjes commented on September 28, 2024

I think this can be done by changing a single line (around line 120) in SparkLineTileSkin:

tickLineColor = Color.color(tile.getChartGridColor().getRed(), tile.getChartGridColor().getGreen(),
                tile.getChartGridColor().getBlue(), 0.50);

from tilesfx.

HanSolo avatar HanSolo commented on September 28, 2024

But like mentioned before there won't be css support in TilesFX. Believe me I have my reasons :)

from tilesfx.

matthjes avatar matthjes commented on September 28, 2024

I understand this, the comment solved the first issue (hard-coded grid line color for SparkLineTileSkin. There is already a property chartGridColor in Tile, but this is never used. So I just changed this SparkLineTileSkin class to use this property for its grid color.

from tilesfx.

HanSolo avatar HanSolo commented on September 28, 2024

Sorry for the late reply, made the suggested modification with commit 25fa824

from tilesfx.

a-benkhaled avatar a-benkhaled commented on September 28, 2024

But like mentioned before there won't be css support in TilesFX. Believe me I have my reasons :)

Hello,
Does adding the css ids and classes result in a performance issue.
If not it's good to add them in case we choose to add a CSS styling.
Thanks

from tilesfx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.