Comments (11)
@jamesagnew would we consider a change of that magnitude?
@Boereck we need a worked test case
from org.hl7.fhir.core.
I realized that there are way, way more places in the code where canonicals are split into URL and version. This would be a herculean task, if test cases shall be provided for each of those changes.
I could start with a PR replacing just the faulty methods with the use of CanonicalPair
with test cases for these changes. I need some time, however, to find out how to test these changes in the best way. When looking into the other places where CanonicalPair
could be used, I realized that a few more helper methods (around the availability of version) on that class would be nice. I could include them (with test cases) in that PR as well.
Further changes to replace splitting in other places could be done bit by bit (maybe module by module). I think this would make the PRs also easier to review.
from org.hl7.fhir.core.
I'm not sure how extensive the changes we'd consider. Just let's start with a worked test case for the supplement issue. In the test-cases repository, a validation test case
from org.hl7.fhir.core.
Alright. Do you mean a new test case in org.hl7.fhir.validation.ResourceValidationTests
with a new resource in org.hl7.fhir.r4/src/test/resources
? Or is there another testing harness that I did not find? Sorry, I am new to this repository and all of it's bells an whistles.
from org.hl7.fhir.core.
Ah, I think I get it: The tests are loaded from the fhir-test-cases
dependency, and the according repository is https://github.com/FHIR/fhir-test-cases/. Should I add the example to the r5 folder only, or also for r4?
from org.hl7.fhir.core.
Just R5
from org.hl7.fhir.core.
I created PR #1614, just with the changes to make the validation work for CodeSystem.supplement canonical with a version.
from org.hl7.fhir.core.
Hello, I realized that the commit message of 5a9ef0b said that the supplement version test case was moved to a normal test case. However, I only see that the test case was removed from ResourceValidationTests
. I don't see the test case where added to a different file. @grahamegrieve , did you forget to commit the file it was added to? Or was the test moved to a completely different place?
from org.hl7.fhir.core.
It was moved to the test-cases repo, which is where those type of tests belong
from org.hl7.fhir.core.
I see, it is then picked up by org.hl7.fhir.validation.tests.ValidationTests
in this repository. Thanks for this insight!
from org.hl7.fhir.core.
All actual errors in the code we've found are taken care of in #1614 and #1663 . There is still a lot of duplication of code where the splitting logic of canonicals into url and version is implemented again and again. As stated in the comments of this issue, changing this would be a big change, and big changes are risky. Maybe this can be tackled piece by piece when code in a file has to be changed anyway, following the "boy scout rule": Leave the code cleaner than you found it.
Since the bugs related to url splitting are now all fixed, I close this issue.
If there is still interest in dedicated PRs replacing duplicate canonical splitting code by the usage of CanonicalPair
, let me know. I could also split the canges into smaller PRs, if desired.
from org.hl7.fhir.core.
Related Issues (20)
- Cannot resolve plugin org.sonatype.plugins:nexus-staging-maven-plugin:<unknown> HOT 1
- Concurrency issues with package cache in validator HOT 22
- Support for fhirpath evaluation
- FHIRPath expression with date math HOT 1
- Mime type checking can't handle dash character
- Boundary functions return incorrect results HOT 2
- Reopen https://github.com/hapifhir/org.hl7.fhir.core/issues/1524 HOT 2
- Validator circular dependency issue
- The `div` field is missing in `Narrative.listChildren` for some versions. HOT 4
- "-no-extensible-binding-warnings" not working properly HOT 1
- Anchors broken in validator html report
- Validator CLI - Loading of profiles via canonical URL doesn't take into account path params HOT 2
- Validator CLI - Loading of profiles via local file doesn't appear to work HOT 2
- Class too large: org/hl7/fhir/r4/formats/JsonParser HOT 4
- FML transform getting very slow for growing/large lists
- FML transform performance - excessive creation of FHIRPathEngine in new Properties
- Make TerminologyCache return non-mutable ValidationResult and ValueSetExpansionOutcome HOT 1
- FHIR EOB : priority attribute error
- Debian package HOT 5
- org.hl7.fhir.dstu3.model.MedicationAdministration does not copy a dosage.extension of type Duration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from org.hl7.fhir.core.