v17.10.0 Typed schema on validate is returning value:any

[Sandy-Garrido]

v17.10.0 Typed schema on validate is returning value:any

[Marsup]

It's more accurately representing reality. In case of error, it contains the best effort result of the validation, but it's certainly not an encouragement to use it.

What is it breaking exactly?

[Sandy-Garrido]

Hmm, I see your case.
Though previously, it would represent the type correctly if you'd throw/return the error.

Following on from the example in my OP. Previously:

const {value, error} = schema.validate(someone)
// value: Person | undefined

if(error){
// throw/return
}

// value: Person
// we correctly would receive value as Person type only instead of before the throwing it could have been undefined 

I feel like this is a pretty major change in that we're now just returning any here considering we just validated it. Now we just see any regardless of whether we escape on error

[Sandy-Garrido]

I think the bug essentially is that TSchema is never displayed because any overpowers it

see this TSPlayground https://www.typescriptlang.org/play?#code/C4TwDgpgBAChBOBnA9gOygXigbwFBQKlQEMBbCALikWHgEtUBzAblwF8oAfKXPQospSjFUIVm1y4AxmhpRISNFTiL0WPoRLkqAIkQiAJiB3tJM1HP2ojmeQhSoAdFoi4A9G+qGQUOomGiQA

type Person = {
    name: string;
} | 
{
    name: any;
}

const person: Person = {
    name: "sandy"
}

const sandy = person.name
// sandy is always any

[Marsup]

It still works if you check the error https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAKQsOAzKERwOQCtnYDcAUMTAJ5gCmcAClVAM4QB2cAvHAN7FxwCGAcyoAuOCwCuIAEYMSfFvxCi4jGFGAtBJAL6kAxqzWrMVVivpNWHbr3FKVAIkb8WAE3KOANHaEqATAAMxHrEhizGjPoAFlQg-DZIwAB0ENK4VPowADyWzCwAfAAUPAoOYknJahpaRQCUPnx+FcjJkjIM9SF1BkbwXABu-AA2ElRecAwYUDo2UbHxyUPDwG78MFRFzMrmdSSkwKhwRQCEU9B1tnx8y2PJfvLXt1T3wlRUusRAA. I guess the only other type that would make sense would be unknown, but it wouldn't change your problem.

[Sandy-Garrido]

Strange, It wasn't working the way I expected at first. Just tried it now and yes, it is working as expected and I agree with the undefined to any change. I thought there was a bug but seems at home it no longer is the case! So will close this now!