can we remove useless information

[happyr]

can we remove useless information

[Nyholm]

In private projects I tend to have @author on each class. Then I know which developer that has done most of the changes in a class. So whenever I have a question I know who to contact.

I do not love the class name though..

@cakper Do you have an opinion about the @author tag?

[cordoval]

i have seen several repos very open to this change https://github.com/stephpy/timeline, the bundle, gushphp, and others, even internally at work I have done the same in several companies and discussed it in length. The con you cited really dilutes since you can find that with git blame. It is actually more precise to know who did what and not just having a name which could become so rapidly stale with so much refactor.

[Nyholm]

Yes and no... You did a lot of PSR-2 fixes, it does not mean you know the algoritm the class may implement.
And what about this class Benjamin did not commit anything...

I see you point and I value it. Let find out what @cakper prefer and go with that.

[cordoval]

correct and that is why the blame does only show in one line. For the cases of Benjamin i think you can do a reference but that is the exception. yeah i am all good I know @cakper rocks 😊

[Nyholm]

👍 =)

[cakper]

@cordoval we agreed with @Nyholm that at the moment this annotation will not bring much value and decided to remove it in one of the upcoming PR's. Thanks for your input :)

[cordoval]

can i send it though? I take joy in doing these things to let you focus on the important stuff. and http://github.com/gushphp/gush makes it a refreshing exercise

[cakper]

@cordoval we are doing major refactoring now anyway so please leave it for now because we have already started and it may cause more trouble with rebasing/merging than needed :) Thanks.

[cordoval]

do you have a branch off of which i can rebase off? I am a long forgotten apprentice of @ornicar 😊 that means I am good at rebasing 👍

[Nyholm]

Fixed by #56