Comments (2)
haroldadmin
commented on May 17, 2024
Thank you for pointing out the issue. I looked into the testing setup as a result and as it turns out, most of the tests are not being picked up by Gradle.
The project right now has 42 tests, but running ./gradlew clean test only executes 18 of them. This is why I missed the broken test in ErrorExtractionTest. I have found there are a few other broken tests too which need fixing.
The reason is that some test classes do not extend from a base class of kotlintest library. I am working on a fix for this.
Regarding the HttpException.extractFromHttpException point, I think you're right. An HTTP exception by definition indicates that an error response was received from the server, so classifying it as something other than a ServerError would be silly.
Feel free to make a PR for this, I am happy to accept external contributions.
from networkresponseadapter.
haroldadmin
commented on May 17, 2024
Closed with #11
from networkresponseadapter.
Related Issues (20)
- Get data frrom Retrofit with обработкой Error and Success HOT 1
- V5.0 HOT 6
- NetworkResponse Error Managing HOT 3
- Success code 204 (no content) returns server error HOT 1
- NetworkResponseAdapterFactory crashes on unhandled response types HOT 1
- ResponseHandler should allow to pass our own converter HOT 5
- moshi exception incorrectly classified as network error HOT 2
- NetworkResponse.UnknownError HOT 2
- How to handle responses with 200 **AND** 204 (No Content) HOT 3
- How To Handle Error Response ? HOT 4
- When expression with Success and Error is not exhaustive HOT 4
- Error when app is builded in release mode HOT 2
- Retrofit mock HOT 2
- How to run this source code in Android Studio??? HOT 8
- Are there any projects that have used this library? (open source) HOT 4
- Binaries not available on Maven Central HOT 4
- 5.0.0 is not backwards compatible HOT 2
- Adding NetworkResponseAdapterFactory to your Retrofit client in Java HOT 3
- Excpetion: Unable to create call adapter when I try to use with Retrofit and Moshi HOT 1
- Application crashing when minifyEnabled is set to true HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from networkresponseadapter.