Comments (19)
Thanks so much for this bug report @sTywin !
I'm debugging it now and will have an explanation shortly.
from epub-press-clients.
I took a deeper look at the seat14c.com/future_ideas
pages and they are unfortunately very large.
Each page is ~4Mb. EpubPress has a limit of 10Mb for any content sent.
Why the error?
nginx
was being used to enforce that limit - it responds with html, but the extension expects json
responses. So when it goes to parse the response it has a bad time.
Results
I've made it so that requests > 10 Mb and < 30 mb will get a friendlier error. Will need an extension update to catch the error for all cases.
I'm going to mark this as closed. Getting all those pages to work with EpubPress would require boosting the limit to
23 * 4Mb = 92 Mb
Allowing books that are ~100Mb large would degrade service for everyone and make the service more expensive to run.
Not the conclusion I had hoped for - sorry :(.
A separate issue exists for the JSON parsing bug, so I'll add these details and continue to track progress there.
Thanks again for the detailed bug report!
from epub-press-clients.
Makes sense, thanks for the update. A friendlier error will help.
from epub-press-clients.
Today I received the same error on all the pages I tried to download, both on Chrome and Firefox.
from epub-press-clients.
Now it works.
from epub-press-clients.
Thanks for the update @bkrlik!
Was off the grid the last few days and something went down 😬
from epub-press-clients.
Again it's no working :(
from epub-press-clients.
Currently experiencing some server issues. Hope to have things back up soon.
Sorry for the inconvenience.
from epub-press-clients.
Things are working again. Thanks again for alerting me @bkrlik !
from epub-press-clients.
How do we get an updated client to fix this? I'm still running into the same issue.
from epub-press-clients.
@jeffrechten
If you're seeing the error it's because too much data is being sent.
The fix would be to log a nice error that says:
Try sending less data...
Could be done in epub-press-js#normalizeErrors
. I can do that this weekend, just hasn't been on the top of my priorities.
from epub-press-clients.
@haroldtreen Would this be expected for one page of data? ~1200 lines, 110k characters.
from epub-press-clients.
@jeffrechten One page doesn't seem like it should be an issue... but it could be? The amount of text on the page isn't what matters as much as the size of the html
in the page. Sometimes pages download content in the background, store it in the page but hidden.
Do you have more information?
- What's the page?
- If you inspect the "background page" do you see any error?
- If you go into the
Network
tab and click thebook
request, is the response?
from epub-press-clients.
@haroldtreen It's a yammer page I am logged into.
After I select the page for the book and click download, there isn't a books
request. Also, the total size is not terribly large: I forced a refresh to capture any cached data.
There are no errors in the console.
from epub-press-clients.
@jeffrechten I think you're looking at an inspector for the yammer webpage.
To see what EpubPress is doing you'll need to:
- Go to chrome://extensions
- Enable Developer Mode
- Inspect the background page for EpubPress (screenshot in previous comment).
That's where the request should be coming from.
from epub-press-clients.
@haroldtreen Okay, I see. Sorry.
Here's what I got:
from epub-press-clients.
@jeffrechten Hmmm... so it's not responding with anything? That seems a bit strange...
What's in the Headers
tab? Would be curious what the outbound request looks like.
What's the second network request? Doesn't look like anything that EpubPress requests.
This is what the output should look like:
And the Headers:
from epub-press-clients.
Published a new version of epub-press-js
that catches this error and returns something nicer.
https://www.npmjs.com/package/epub-press-js
Now just need to update the chrome extension.
from epub-press-clients.
@haroldtreen I noticed that the request was getting caught by a corporate proxy so that is why it wasn't making it to the server side.
from epub-press-clients.
Related Issues (20)
- code block rendering error
- file title in unknown | kindle HOT 5
- rtl issues
- Epub-press as a bookmarklet ? HOT 1
- Generate native EPUB table of contents HOT 1
- Single tab selection
- Is it possible to download the content on the OpenStax website to a local EPUB file?
- How to set the server URL to use?
- Firefox extension sticks on "fetching images" again and again HOT 5
- Firefox extension omits all text from some pages, splits it one line per page from other pages
- feature request: config to download comments on reddit
- Extension dark mode icon
- .mobi file always gets the default title HOT 2
- Support Custom Cover Pages
- Not Downloading
- tilde ~ in filename causes EpubPress to hang in Brave browser
- How Can I Change The User-Agent of EpubPressJs? HOT 9
- why did we had the size limitations of EpubPress? HOT 1
- Picture of Content can't get
- Lazyloaded image can't show
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from epub-press-clients.