Giter Site home page Giter Site logo

Comments (19)

haroldtreen avatar haroldtreen commented on May 18, 2024

Thanks so much for this bug report @sTywin !

I'm debugging it now and will have an explanation shortly.

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

I took a deeper look at the seat14c.com/future_ideas pages and they are unfortunately very large.

image

Each page is ~4Mb. EpubPress has a limit of 10Mb for any content sent.

Why the error?

nginx was being used to enforce that limit - it responds with html, but the extension expects json responses. So when it goes to parse the response it has a bad time.

Results

I've made it so that requests > 10 Mb and < 30 mb will get a friendlier error. Will need an extension update to catch the error for all cases.

I'm going to mark this as closed. Getting all those pages to work with EpubPress would require boosting the limit to

23 * 4Mb = 92 Mb

Allowing books that are ~100Mb large would degrade service for everyone and make the service more expensive to run.

Not the conclusion I had hoped for - sorry :(.

A separate issue exists for the JSON parsing bug, so I'll add these details and continue to track progress there.

Thanks again for the detailed bug report!

from epub-press-clients.

sTywin avatar sTywin commented on May 18, 2024

Makes sense, thanks for the update. A friendlier error will help.

from epub-press-clients.

bkrlik avatar bkrlik commented on May 18, 2024

Today I received the same error on all the pages I tried to download, both on Chrome and Firefox.

from epub-press-clients.

bkrlik avatar bkrlik commented on May 18, 2024

Now it works.

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

Thanks for the update @bkrlik!

Was off the grid the last few days and something went down 😬

from epub-press-clients.

bkrlik avatar bkrlik commented on May 18, 2024

Again it's no working :(

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

Currently experiencing some server issues. Hope to have things back up soon.

Sorry for the inconvenience.

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

Things are working again. Thanks again for alerting me @bkrlik !

from epub-press-clients.

jeffrechten avatar jeffrechten commented on May 18, 2024

How do we get an updated client to fix this? I'm still running into the same issue.

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

@jeffrechten
If you're seeing the error it's because too much data is being sent.
The fix would be to log a nice error that says:

Try sending less data...

Could be done in epub-press-js#normalizeErrors. I can do that this weekend, just hasn't been on the top of my priorities.

from epub-press-clients.

jeffrechten avatar jeffrechten commented on May 18, 2024

@haroldtreen Would this be expected for one page of data? ~1200 lines, 110k characters.

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

@jeffrechten One page doesn't seem like it should be an issue... but it could be? The amount of text on the page isn't what matters as much as the size of the html in the page. Sometimes pages download content in the background, store it in the page but hidden.

Do you have more information?

  • What's the page?
  • If you inspect the "background page" do you see any error?
    image
  • If you go into the Network tab and click the book request, is the response?
    image

from epub-press-clients.

jeffrechten avatar jeffrechten commented on May 18, 2024

@haroldtreen It's a yammer page I am logged into.

After I select the page for the book and click download, there isn't a books request. Also, the total size is not terribly large: I forced a refresh to capture any cached data.
image

There are no errors in the console.

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

@jeffrechten I think you're looking at an inspector for the yammer webpage.

To see what EpubPress is doing you'll need to:

  • Go to chrome://extensions
  • Enable Developer Mode
    image
  • Inspect the background page for EpubPress (screenshot in previous comment).

That's where the request should be coming from.

from epub-press-clients.

jeffrechten avatar jeffrechten commented on May 18, 2024

@haroldtreen Okay, I see. Sorry.
Here's what I got:

image

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

@jeffrechten Hmmm... so it's not responding with anything? That seems a bit strange...

What's in the Headers tab? Would be curious what the outbound request looks like.
What's the second network request? Doesn't look like anything that EpubPress requests.

This is what the output should look like:

image

And the Headers:

image

from epub-press-clients.

haroldtreen avatar haroldtreen commented on May 18, 2024

Published a new version of epub-press-js that catches this error and returns something nicer.

https://www.npmjs.com/package/epub-press-js

Now just need to update the chrome extension.

from epub-press-clients.

jeffrechten avatar jeffrechten commented on May 18, 2024

@haroldtreen I noticed that the request was getting caught by a corporate proxy so that is why it wasn't making it to the server side.

from epub-press-clients.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.