Giter Site home page Giter Site logo

Comments (6)

haruny avatar haruny commented on August 20, 2024

yes. when you have a shaky internet connection and the response fails, it might do this.
I'll add some error handling.

from adt-pulse-mqtt.

haruny avatar haruny commented on August 20, 2024

added error handling here in 0.2.1.2

from adt-pulse-mqtt.

vmweaver avatar vmweaver commented on August 20, 2024

Thank you! Very much appreciate the fine work you are doing here.

from adt-pulse-mqtt.

vmweaver avatar vmweaver commented on August 20, 2024

Seems I am getting another error on the new version.
It looks like "body" may be NULL in some case, would it make sense to handle that as a catchall?
I do have a solid internet connection, so I am not sure what would be causing this so regularly. I will dig into that more.
Thanks again!

2018-8-3 06:37:12 Pulse.getDeviceStatus No other devices found
2018-8-3 06:37:12 Pulse.Sync: Syncing 10071-0-0
2018-8-3 06:37:12 Pulse: updateAll
2018-8-3 06:37:12 Pulse.getAlarmStatus: Getting Alarm Statuses
2018-8-3 06:37:17 Pulse.Sync: Syncing 10071-0-0
2018-8-3 06:37:22 Pulse.Sync: Syncing 10071-0-0
/usr/src/app/adt-pulse.js:297
if (body.includes("You have not yet signed in")){
^
TypeError: Cannot read property 'includes' of undefined
at Request._callback (/usr/src/app/adt-pulse.js:297:14)
at self.callback (/usr/src/app/node_modules/request/request.js:185:22)
at emitOne (events.js:116:13)
at Request.emit (events.js:211:7)
at Request.onRequestError (/usr/src/app/node_modules/request/request.js:877:8)
at emitOne (events.js:116:13)
at ClientRequest.emit (events.js:211:7)
at TLSSocket.socketErrorListener (_http_client.js:387:9)
at emitOne (events.js:116:13)
at TLSSocket.emit (events.js:211:7)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: node server.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/2018-08-03T11_37_23_104Z-debug.log

from adt-pulse-mqtt.

haruny avatar haruny commented on August 20, 2024

thanks for the feedback!
I'm not sure why it would fail to get the "body". Maybe pulse's service is up/down?
Definitely mode error handling can help.

from adt-pulse-mqtt.

vmweaver avatar vmweaver commented on August 20, 2024

After the last update, this is solid! Thanks.

from adt-pulse-mqtt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.