Check usernames against userids

[jace]

Check usernames against userids

[kracekumar]

Lastuser expects username to be in lower characters(https://github.com/hasgeek/lastuser/blob/master/lastuser_oauth/forms/profile.py#L67).

newid from coaster which generates userid will contain at least one uppercase character.

In [46]: r = []

In [47]: for i in range(100000):
    new_id = newid()
    for c in new_id:
        if c.isupper():
            r.append(True)
            break
   ....:

In [48]: len(r)
Out[48]: 100000

is it safe to assume User B's username will not collide with User A's userid because one character in userid will be uppercase ?

[jace]

Not a safe assumption. It's base64 and that could be lowercase or uppercase.

[miteshashar]

@jace You already handled this here? https://github.com/hasgeek/lastuser/pull/67/files#L5R59

[jace]

Yes, this is now resolved.

[miteshashar]

We should use the commit messages to close these. Makes life easy, I guess.

@kracekumar Apart from changing status of issue, tagging commits with issues always helps sequentially understand how the issue was sorted. That is basically what I'd been trying to convey.

[miteshashar]

@jace Won't we need tests for these?

[jace]

Slightly tricky to write a test at the moment because we require usernames to be lowercase right now and userids are almost always mixed case. The lowercase requirement comes from within is_valid_username (IIRC, since coaster.valid_username requires lowercase).

If we relax the lowercase requirement in future, opting for case-insensitive usernames, this will need a test.

[kracekumar]

@miteshashar I have been doing that check hasgeek/hacknight#236. There are reasons I do it manually.

1. If pull request din't fix the issue, I need to reopen the status of the issue.

Once code is merged then I place a commit with pull request id or commit sha.

[miteshashar]

Github has changed this. Github does not close the issue, unless the pull request is merged into master.