Why Combinator is not making all possible combinations?

[hashcat]

Why Combinator is not making all possible combinations?

[Xanadrel]

It's just in the source :

hashcat-utils/src/combinator.c

Line 14 in 0469d0e

#define LEN_MAX 32

Line length limit is set to 32, if you change the order of your files it works because at step 2 all lines are under 32 characters :

$ ./combinator3.exe qaz.txt wsx.txt 12345.txt > combi3.out

$ ./combinator.exe qaz.txt wsx.txt > combi.step1.out
$ ./combinator.exe combi.step1.out 12345.txt > combi.step2.out

$ sort -u -o combi3.out combi3.out
$ sort -u -o combi.step2.out combi.step2.out

$ wc -l *.out
    256 combi.step1.out
 226560 combi.step2.out
 226560 combi3.out
 453376 total

$ md5sum.exe *.out
1a5c439c15b44f8217420f6455d3aaf6 *combi.step1.out
add1e0561949f11082517f70cd43f206 *combi.step2.out
add1e0561949f11082517f70cd43f206 *combi3.out

You can also easily increase the limit and recompile depending on your needs :)

[Wikinaut]

I would like to propose the increasement of this value to, for example, 256. Would you accept such a regular pull request?