Comments (11)
Awesome! Let us know if you need any help or have any question. :)
from golang-lru.
@venkatsvpr Great to hear from you! Thanks for your support.
Btw, I think it might be better to integrate SIEVE in an opt-in manner.
from golang-lru.
I have been using golang-lru repo for many years now. Thanks everyone who contributed.
I read the Sieve paper and it is super cool. I would like to volunteer to integrate sieve into golang-lru.
Thanks!
cc - @yazhuo
from golang-lru.
Yes - Agree!
from golang-lru.
Hi folks, @irenarindos @mgaffney @paskal
Want to touch base with you to see if the proposal make sense to you.
Thanks!
from golang-lru.
Hi!
We are interested in seeing a more detailed proposal. Keep in mind that any proposed changes should not change the default behavior or characteristics of the current v2 implementation (meaning using SIEVE would have to be optional). We could then gather feedback from users and consider making it the default in the next revision (v3).
from golang-lru.
Hi @mgaffney Thanks for getting back.
I have added two New methods (NewSieve and NewSieveWithEvict) which would work with SIEVE evicition.
Please take a look at this PR and add your comments.
from golang-lru.
@venkatsvpr that PR is not for this repo
from golang-lru.
Yes. Let me complete the PR and send out another PR for this repo. Thanks!
from golang-lru.
I've updated the PR #169
Please take a look.mgaffney
Also, if & when there is a v3 version, It'd be great with the change the New signature. This would make us future proof the new changes we might have. (like sieve)
from golang-lru.
@mgaffney Did you get a chance to check out the PR #169
Let me know if I can be of any help.
Thanks!
from golang-lru.
Related Issues (20)
- Why does TwoQueueCache have no onEvicted callback? HOT 1
- Please don't break public API without major bump HOT 1
- onEvicted is called with incorrect item when a previous Add overwrites an existing item HOT 11
- v2.0.3 introduced breaking changes and is breaking our build HOT 9
- how to update the cache element ? HOT 1
- Is there a plan to add an interface to get the capacity of the lru-cache
- Did you empty 1.01v HOT 1
- Expirable LRU can return nil value with ok = true HOT 3
- Example output is not matched with actual output HOT 4
- AddMany?
- Why Expirable-LRU delete Close method? HOT 5
- Delayed deletion of entries in expirable cache HOT 1
- we have encounter an strange panic, we still working on it. HOT 1
- How to update a key expiration in the cache? HOT 3
- Request for `RemoveWithoutEvict` API.
- The return of the example is inconsistent with the actual return
- Suggestion for GetWithExpiration method for expirable cache
- Addition of AddWithTtl to Expirable cache HOT 1
- index out of range panic while calling "Keys()" function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from golang-lru.