Member role not updated when re-joining cluster

[hashicorp]

Member role not updated when re-joining cluster

[armon]

@kainosnoema Good catch! Just pushed a change to master that should fix this. Its an issue of us just forgetting to update the node meta data on the re-join.

[armon]

Let me know if that fixes it, and I can close the ticket!

[kainosnoema]

Hmm... thanks for the incredibly quick response, but after pulling, building and running the test case again, I'm seeing the same result. Your fix looks reasonable, but somehow it's still not being updated. Tested on: Serf v0.2.1.dev (727963506453a17d78f09154dc52b78a4a1beaf4).

[kainosnoema]

@armon I have a feeling the relevant section might be here:

serf/serf/serf.go

Lines 574 to 578 in 7279635

	} else {
	oldStatus = member.Status
	member.Status = StatusAlive
	member.leaveTime = time.Time{}
	}

[kainosnoema]

The spot you updated is related to nodes that have left the cluster, but we still have a leaving intent for it, whereas I'm testing a failed node that's still in the members list. It might be nice to de-duplicate some of that similar "rejoining" code. :/

[armon]

Yeah I don't know what the hell I was thinking... I had an intuition it was a bug in that method, but I just put the code in a completely irrelevant block. I moved those two lines to the area you indicated. But it looks like a more subtle issue involving Memberlist.

[armon]

Looks like it was due to a similar bug upstream in Memberlist. I've updated master on both, can you please try to update dependencies and try the latest build?

[kainosnoema]

Yup, that fixed it (hashicorp/memberlist@c9b8047 and 10511cd). Thanks!

[mitchellh]

Given how this was our only bug reported in a week of 0.2, I think it is safe to push this out in a 0.2.1 right away. Will release.