Comments (9)
@kainosnoema Good catch! Just pushed a change to master that should fix this. Its an issue of us just forgetting to update the node meta data on the re-join.
from serf.
Let me know if that fixes it, and I can close the ticket!
from serf.
Hmm... thanks for the incredibly quick response, but after pulling, building and running the test case again, I'm seeing the same result. Your fix looks reasonable, but somehow it's still not being updated. Tested on: Serf v0.2.1.dev (727963506453a17d78f09154dc52b78a4a1beaf4)
.
from serf.
@armon I have a feeling the relevant section might be here:
Lines 574 to 578 in 7279635
from serf.
The spot you updated is related to nodes that have left the cluster, but we still have a leaving intent for it, whereas I'm testing a failed node that's still in the members list. It might be nice to de-duplicate some of that similar "rejoining" code. :/
from serf.
Yeah I don't know what the hell I was thinking... I had an intuition it was a bug in that method, but I just put the code in a completely irrelevant block. I moved those two lines to the area you indicated. But it looks like a more subtle issue involving Memberlist.
from serf.
Looks like it was due to a similar bug upstream in Memberlist. I've updated master on both, can you please try to update dependencies and try the latest build?
from serf.
Yup, that fixed it (hashicorp/memberlist@c9b8047 and 10511cd). Thanks!
from serf.
Given how this was our only bug reported in a week of 0.2, I think it is safe to push this out in a 0.2.1 right away. Will release.
from serf.
Related Issues (20)
- When a serf member is leaving the pool using `Leave` if `messageLeaveType` broadcast fail, the leave is not completed
- maybe mark `v0.9.6` as the latest release?
- Release latest binaries HOT 2
- response size check on keyListResponseWithCorrectSize breaks with 32bit keys and keyring size >20
- Data race related to query Ack channel
- Is Serf suitable for integration into the kubernetes app as a library?
- When the nodes leave and start at the same time in a large-capacity consul cluster, some member states will continue to keep leaving, not alive.
- Upgrade kramdown package used in Website Gemfile.lock to version 2.3.0+ to fix Remote Code Execution CVE-2020-14001
- Can't bind Serf agent to IPv6 address
- serf panics on MacOS when waking up from sleep during a network switch
- serf agent panic when -iface and -discover is given HOT 2
- serf: protect field access with lock to avoid potential data race
- [Question] User events to a node rejoining the cluster
- Is this a small typo? Should read start and stop?
- Please, Upgrade armon/go-metrics to hashicorp/go-metrics HOT 2
- Question regarding the estimation of the latency between two kubernetes clusters using serf
- Unix Domain Sockets for the RPC address.
- Using as a library of managing membership, Is serf just provides a different/better implementation of memberlist? HOT 2
- Unable to Access Vivaldi Coordinates HOT 2
- Connected node would remain in "alive" state indefinitely after unplugging Ethernet cable connecting two agents HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serf.