archive_file uses backslashes in zipped files' paths on Windows

archive_file uses backslashes in zipped files' paths on Windows

[MrDweebus]

@reflectivecode
Ah, I wasn't aware there hadn't been a release yet.

I've tried locking the archive provider to 1.0.0 using the snippets:

provider "archive" {
  version = "<= 1.0"
}

and

provider "archive" {
  version = "1.0.0"
}

When pushed to the Lambda, both still create files with names like 'node_modules\library\library.js'. I've also tried on a windows laptop instead of a VM, to no avail.

I second @MrDweebus - I have also tested various releases of archive, but I still see backslashes in the output files.

[samjgalbraith]

Even forcing the earliest release of archive doesn't fix it for me. This makes lambda using any non-standard-library functions pretty hard.

provider "archive" {
  version = "<= 0.1.0"
}

[reflectivecode]

I started having this problem on provider.archive v1.0.1. Going back to v1.0.0 fixed it for me.

[apparentlymart]

Thanks for reporting that detail, @reflectivecode!

I'm not sure yet why behavior would be different in v1.0.0 since it appears that it's always been required for us to pass forward-slashed paths in here (per golang/go#5307) and we weren't doing it in 1.0.0 either 😖 .

Possibly this can be fixed just by passing the final path through filepath.ToSlash, but I've not been able to verify that due to my attention being currently focused elsewhere. We'd be happy to review a pull request if you or someone else has the time and motivation to implement it, or else we'll take a look more closely at this when we're able.

[lafferty151]

Any idea if this issue comes from a recent change or when it was introduced? We have been trying to determine when or what might have triggered it, because everyone on my team didn't notice the issue until a week or so ago. Could have sworn things were fine for months prior to then. Cannot seem to figure out what might have changed. I've rolled back 3 or 4 versions trying to find that working scenario again. Any thoughts?

[lafferty151]

#19

[derBroBro]

Same for me.
Like @reflectivecode mentioned this worked for me also until the PR gets mereged.

provider "archive" {
  version = "<= 1.0"
}

[katbyte]

Closing as it appears #19 was closed in favour of #25 (merged) so this should be fixed now.

[MrDweebus]

I'm still having an issue with this when using an archive_file to zip up code for an AWS Lambda. I've tried using both v1.0.3 and v1.0.0 of the archive provider to no avail.

Is anyone else still experiencing this? Would it have anything to do with the fact that I'm running the Terraform on a Windows VM?

[reflectivecode]

@MrDweebus

The fix for this problem is not in v1.0.3. We have to wait for a new release first.

Edit:
v1.0.0 does work for me on Linux and Windows (AWS VM). Did you try specifying the version exactly?

provider "archive" {
  version = "= 1.0.0"
}

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.