Creating IP addresses that do not format the same when read back fails

[hashicorp]

Creating IP addresses that do not format the same when read back fails

[bodgit]

I raised #13 to fix this for IPv6 records nearly three months ago and have so far had no feedback. The IPv6 failure case is more obvious as you have the :: expansion to handle; some resources return the IPv6 address in attributes fully expanded whereas miekg/dns compresses the address where possible so they sometimes will never match.

I can easily extend my patch to also canonicalise IPv4 addresses using the same technique.

[cdybedahl]

Yes, it was the IPv6 case that I first ran into (Digital Ocean returns IPv6 addresses for droplets in an expanded form), and when I looked into it I saw that it can happen for IPv4 as well. And it would seem to make more sense to have one patch for both problems, since they are essentially the same.

[bodgit]

I also encountered it for DO droplets 😄

The IPv4 case is interesting as some tools will treat the zero-padding as an octal number so your example works fine but for numbers greater than 007 different tools interpret it differently. I've just checked Go and its net.ParseIP() seems to just see leading zeros as padding rather than treat the number as octal.

See https://superuser.com/questions/857603/are-ip-addresses-with-and-without-leading-zeroes-the-same/857787 for a discussion.

[bodgit]

I've updated my PR #13 to also cover IPv4 addresses.

[apparentlymart]

Hi @cdybedahl and @bodgit!

Sorry for the slow response here. I've now merged #13, so this issue should be fixed in master.

[katbyte]

As mentioned above, looks like this was fixed by #13.

[katbyte]

Hi @cdybedahl,

Just wanted to let you know that we have released v2.0.0 of the provider containing the fix 🙂

[cdybedahl]

Excellent. Thank you!