Giter Site home page Giter Site logo

Comments (3)

indietyp avatar indietyp commented on June 1, 2024

To fix this, we could either

  1. update the tests and CI (single PR) - because we already only compiletest on nightly
  2. use rustversion to conditionally emit additional code on toolchains that are newer than 2022-07-20

(from the logs of #892 it also seems like the code to fetch the nightly toolchain version seems broken)

@TimDiekmann what do you think?

from hash.

TimDiekmann avatar TimDiekmann commented on June 1, 2024

Thanks for filing this!

I think the easiest way is to simply bump the nightly version used in CI, this will also fix #898. I will do this tomorrow.

(from the logs of #892 it also seems like the code to fetch the nightly toolchain version seems broken)

Currently, it uses the first rust-toolchain.toml file it finds in the repository to determine the nightly version, this is why we currently try to keep the nightly versions on par between the different projects (package/engine, packages/libs/error-stack and packages/graph(on dev/graph) ). Probably there is a better way to this, but I haven't investigated this yet.

from hash.

indietyp avatar indietyp commented on June 1, 2024

What I specifically mean is the error:

Run nightly=$(cat $(find . -name rust-toolchain.toml) | grep channel | cut -d\" -f2)
parse error: Invalid literal at line 2, column 0
use toolchains: 

Which turns up in the CI.

from hash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.