Comments (5)
HashNuke
commented on June 18, 2024
@tuvistavie Yes. Let's make the change. Please do send a PR.
from hound.
danhper
commented on June 18, 2024
@HashNuke Thanks for the fast reply. Do you want me to go with {:ok, element} and the bang function, or with a custom error?
from hound.
HashNuke
commented on June 18, 2024
@tuvistavie I would suggest the error. Because the return value of find_element needs to be pipe-able to the next helper function.
So find_element would return an element or nil and find_element! would raise an error if not found.
from hound.
danhper
commented on June 18, 2024
@HashNuke Good point, let's go with this. I'll send a PR as soon as I'm done.
from hound.
HashNuke
commented on June 18, 2024
Closing since this has been fixed.
from hound.
Related Issues (20)
- Any API function can return {:error, :closed} HOT 1
- "catch" should always come after "rescue" in try [Question] HOT 1
- anonymous functions in execute_script
- Fix broken source links from hexdocs HOT 1
- Hound + Selenium/Firefox does not work with `find_element` HOT 3
- set_cookie error with ChromeDriver
- release a new version? is this package still maintained? HOT 2
- Can "other element would receive the click" become an error?
- (RuntimeError) invalid session id when running on alpine HOT 9
- Change driver in start_session
- Problem with acceptance test in hound not starting server on port 4001 in phoenix HOT 2
- Could not transform value %{"element-6066-11e4-a52e-4f735466cecf" => "d2c5deba-fdff-48db-b319-694aa6542c81"} to element HOT 2
- Support w3c for latest chrome / chromedriver releases HOT 2
- Using hound on Heroku HOT 2
- Incomplete list of keys in the documentation of set_keys
- 1.1.0 3be56f4 mismatch between github and hex HOT 5
- Should all retries load from :retries configuration value? HOT 1
- chromedriver can't start automatically HOT 2
- Improvement: the retry argument of find_element
- fill_field(email, "[email protected]")) transforms `@` into `_`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hound.