Comments (10)
I think what we'll do is once 7.8 is out we'll #ifdef
a
import Prelude hiding (join)
for GHC >= 7.8.
from containers.
I'm afraid that won't silence the warning... I just tried with GHC HEAD with the following dummy module:
module Foo (join) where
import Prelude ()
join :: ()
join = ()
See also GHC #8004 for details about this new "feature".
from containers.
Ugh. Why not? What are you supposed to do?
from containers.
Maybe we can just rename join
. That way we would not need any preprocessor magic.
from containers.
I'm OK with that, but I also want to follow up with GHC HQ to see why the fix (hide the import) doesn't work. How about glue
instead of join
? :)
from containers.
@tibbe Fwiw, you could also add an ifdef'ed {-# OPTIONS_GHC -fno-warn-amp #-}
to that module; but please, follow up on that GHC ticket.
from containers.
We already use glue
in Set and Map which is join without a root, i.e.,
glue :: Map k a -> Map k a -> Map k a
join :: k -> a -> Map k a -> Map k a -> Map k a
What about link
? We could also use node
if we rename the node
used in printing...
from containers.
I don't care much either way as long as the function is documented clearly and we don't break the public API.
from containers.
Thanks Johan for commenting GHC #8004. Lets wait and see if the GHC behaviour is modified and if so, use your first suggestion import Prelude hiding (join)
.
from containers.
Just pushed the changes to silense the warnings. I do not have build of GHC 7.7, so I only hope the warnings will be gone. If not, please reopen the issue.
Update: the commits are 5b7e912, 501fa5b and c58285c.
from containers.
Related Issues (20)
- Set difference and union in one HOT 4
- foldTree does not optimize well HOT 2
- Tree fusion HOT 16
- Fusible Set.fromDistinctAscList definition HOT 10
- Fusible IntSet.fromDistinctAscList definition HOT 3
- NonEmpty for CyclicSCC HOT 11
- better instance Hashable IntSet? HOT 8
- Unusual definition of foldrBits and foldlBits HOT 3
- Unnecessary CPP and C header in `Data.Map.Internal.Debug.html`?
- Release for GHC 9.8.1 HOT 17
- feat request: Add `popLeftWithValue` and `popWithValue` in `Data.Sequence` HOT 5
- Data.Graph: detect cycles utility functions HOT 2
- Data.Map.mergeWithKey doesn't match documentation
- Flag to introduce pedantic invariant checks? HOT 2
- Map.unionWith is over specialized and not consistent with intersectionWith HOT 10
- Add `flattenSCC1 : SCC vertex -> Data.List.NonEmpty.NonEmpty vertex` HOT 2
- Data.Map.Internal does not export insertMin
- Repo: remove merged branches?
- Contribution guide outdated?
- Potential memory optimization for IntMap and IntSet HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from containers.