Comments (1)
I would like to open discussion about simplifying and unifying code samples. The idea behind is to provide unified experience to users and allow QE to verify the samples in a CI job.
+1
use one main class per sample and unify its name across the samples
The key idea of the samples is to have it as simple as possible. Some of the samples have more simple classes with main methods. When you want to introduce just one per sample, you will have to merge it into one class -> the class will become bigger and even though there will be simple methods, it's not as beautifully readable as now. And we do not sacrifice readability here at any chance. However, I'm +1 for unifying the name
shut down the whole cluster at the end of each sample
Some of the samples are written the way that you start member and then you add clients and you can add as many clients as you want. Again, it's super simple and easily readable, separating member and the client, what needs to be done on server side and what on client side. Since it's separated this way, you cannot really shut it down easily after you're finished, because the (usually) member cannot really know, if you're finished.
remove shell scripts - the maven-exec-plugin shall be used instead (lets provide README.md where necessary)
+1
use System.out to print what the samples do
+1
I was going the same direction when I was reviewing the samples. Here I just listed a few things that came to consideration, maybe this time we will be able to find better solution :)
from hazelcast-code-samples.
Related Issues (20)
- variable-replacers does not compile anymore HOT 1
- Remove dependencies on old versions HOT 3
- How To use group in version 4.0.1 HOT 2
- Documentation: Kubernetes external client failure on Minikube HOT 1
- Documentation: Kubernetes on Minikube for WAN
- Why are the samples using /hazelcast/health/node-state for OpenShift/Kubernetes readiness & liveness probe? HOT 2
- Configure XML does not work anymore HOT 4
- Where is the log history for each new release? HOT 2
- DistributedObjectDestroyedException: AtomicValue[xxx] is already destroyed! HOT 1
- 'SPI: Implementing tenant control 0.1-SNAPSHOT' does not compile HOT 2
- Faild to Build ocp-demo-frontend-s2i
- Is it possible to keep data sorted?
- serialization/benchmark cannot be compiled with JDK 8 + checkstyle violations
- Dependency org.apache.mina:mina-core, leading to CVE problem HOT 1
- Code sample 'Serialization: Compact' cannot be compiled with current HZ master
- UPDATE sql statement
- Getting memory leak error when upgrading hazelcast version to 3.11 from 3.10.7
- hazelcast code sample for XA transactions no longer works with current Atomikos version (5.0.9) HOT 4
- Update Neo4j driver in KafkaConnectSample after migration to JDK11
- Jet-jms module cannot be compiled with current HZ master
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hazelcast-code-samples.