Giter Site home page Giter Site logo

Comments (1)

Holmistr avatar Holmistr commented on June 25, 2024

I would like to open discussion about simplifying and unifying code samples. The idea behind is to provide unified experience to users and allow QE to verify the samples in a CI job.

+1

use one main class per sample and unify its name across the samples

The key idea of the samples is to have it as simple as possible. Some of the samples have more simple classes with main methods. When you want to introduce just one per sample, you will have to merge it into one class -> the class will become bigger and even though there will be simple methods, it's not as beautifully readable as now. And we do not sacrifice readability here at any chance. However, I'm +1 for unifying the name

shut down the whole cluster at the end of each sample

Some of the samples are written the way that you start member and then you add clients and you can add as many clients as you want. Again, it's super simple and easily readable, separating member and the client, what needs to be done on server side and what on client side. Since it's separated this way, you cannot really shut it down easily after you're finished, because the (usually) member cannot really know, if you're finished.

remove shell scripts - the maven-exec-plugin shall be used instead (lets provide README.md where necessary)

+1

use System.out to print what the samples do

+1

I was going the same direction when I was reviewing the samples. Here I just listed a few things that came to consideration, maybe this time we will be able to find better solution :)

from hazelcast-code-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.