Comments (1)
👋 I've been working with Olivier on this and was doing some code archeology from discussion on our internal PR. To help answer his question I'm pretty sure this is a leftover from older times, which turned into a little bit of parallel development. The timeline I put together:
18a18e4 (Jun 16, 2012) added the send_devise_notification
hook. The latest Rails version was 3.2 at the time.
c25312e (Sep 2, 2014) added the section to the readme, which hasn't changed since. This was just before the release of Rails 4.2 on December 19, 2014 which included Active Job and ActionMailer#deliver_later.
Meanwhile, 2e442d8 (May 12, 2016) removed the deprecation from the send_devise_notification
hook example that was introduced in Rails 4.2, and c9a2d06 (Mar 23, 2018) changed the example to use deliver_later
.
tl;dr I think it's fine to remove the send_devise_notification
hook example (or change it to match the readme example). FWIW #5610 would make this more intuitive to configure, and hopefully enable a switch of the default to deliver_later
in the next major release.
from devise.
Related Issues (20)
- Password Reset Workflow Question 🔍 HOT 1
- Deprecation - Rails.application.secrets HOT 6
- undefines method utc in reset_password_period_valid? method HOT 3
- How to Expire Session IDs in Cookies for Active Admin?
- DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. HOT 2
- Possibly incorrect skip_trackable check for timeoutable
- strong params not working as per "lazy way" instructions
- Sorbet support for Devise Controllers
- ActionController::InvalidAuthenticityToken in Devise::SessionsController#create HOT 14
- "Encrypted password" is actually "Hash" of the password. Does it need to be renamed?
- Error during failsafe response: uncaught throw :warden HOT 1
- `confirmation_sent_at` is set regardless `skip_confirmation_notification!` method call HOT 1
- Resend confirmation instructions triggering error HOT 1
- Replace [data-turbo-cache=false] with [data-turbo-temporary]
- `parent_mailer` config option boot error
- Converting views from Erb to Haml causes them to be ignored by Devise HOT 1
- How to prevent to send a confirmation email when email field is updated ? #903 HOT 1
- user.update_with_password ignores password_confirmation
- Deprecation warning about Rails.application.secrets on rails 7.1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise.