Comments (4)
Actually, ||=
would do since the default is false
, no need to check for nil
especially.
from responders.
If you change this value after Rails is initialized, then they won't propagate. I am not really a fan of depending on Rails.application.config.responders
, but here is what we could do:
- Move the configuration options to
Responders
, so we would haveResponders.namespace_lookup
- Make
Rails.application.config.responders = Responders
If you want to change that, a patch is welcome. :) Thanks a lot for your contributions!
from responders.
@josevalim is it still make sense? If so could you explain a bit how it'll help with current issue? :) Not sure I understood it right.
from responders.
@nashby by doing Rails.application.config.responders = Responders
, we'll be able to use Rails.application.config.responders.namespace_lookup = true
in an initializer as @marcandre expects, because the end result would be the same as setting Responders.namespace_lookup = true
.
Right now we use an initializer
hook to do that, which means the configuration will be already propagated at the time Rails requires config/initializers
, so setting the config there won't work.
@josevalim it's just going to be a bit weird to use Responders.namespace_lookup
instead of Responders::FlashResponder.namespace_lookup
since the configs are only related to the flash one. A quick way of doing less changes is setting config.responders
to the FlashResponder
, since it's the only one that actually have configs :D. But, I think we can live with that anyway.
from responders.
Related Issues (20)
- Release a v2.4.1 to test Responders running on application using Rails 6.0.0lapha HOT 2
- Rails 6 RC1 HOT 1
- Doesn't Always Respect Domain Constraint HOT 2
- Template lookup order, and strict request format HOT 1
- Test Rails 6 with 2.4.x branch HOT 1
- private method `render' called HOT 2
- `redirect_to` cannot be called from `navigation_location` method HOT 3
- Errors not properly serialized in Rails API-Mode HOT 1
- Redirect uses status code 302 which does not work with Turbo HOT 6
- Creating an object returns a 200 instead of a 201! HOT 1
- Turbo-streams and turbo-frames with responders HOT 13
- Explicitly set status gets overriden HOT 1
- undefined method `redirect_status'
- `location` compatibility with `allow_other_host`
- New Release HOT 8
- Custom redirect_status only available when a flash YAML file exist HOT 5
- CodeClimate maintinability badge is not working
- Providing status as option doesn't work in 3.1.0 if has_errors?
- Namespaced Models and the Collection Responder
- Latest release does not show in releases tab HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from responders.