Giter Site home page Giter Site logo

Comments (9)

HeathWang avatar HeathWang commented on May 28, 2024

可以,我看下
@fuchenxi 确定抛出这一个代理方法就可以了吗?

from hwpanmodal.

fuchenxi avatar fuchenxi commented on May 28, 2024

我建议所有的都抛出。
因为复杂的手势需求这种代理都需要使用。 还有就是建议代理API可以优化更新个大版本了,这个库我也用了很多年了。整体使用感觉挺不错的,就是实现代理方法还是觉得有些啰嗦了。可以出一个类似于 UIAppearance 的全局配置项,适用于整体,控制器的方法,改成属性比如 :

vc.hw_pushAnimation.springDamping
vc.hw_popAnimation.springDamping
vc.hw_interaction

hw_pushAnimationhw_popAnimationvc.hw_interaction 可以遵循某个协议,让客户端可以自定义实现。
-presentPanModal: 改成 hook 系统的 presentViewController:, 使用自己的还是系统的,可以给控制器添加一个开关属性。
总的来说,就是 动画、手势、交互等都可以单独剥离开。现在在一个协议里确实越来越复杂啦。
只是建议~~~这是个大工程

from hwpanmodal.

HeathWang avatar HeathWang commented on May 28, 2024

拆分的协议越多,颗粒度是变小了,但是一般人刚入手理解使用也难度加大。
原本做的很简单,后面发现提的需求越来越多,一个协议就变得很大了。

我看看把所有的手势代理抛出来吧。
拆协议不确保不出bug,目前没这个计划,毕竟测试全靠同行。

from hwpanmodal.

HeathWang avatar HeathWang commented on May 28, 2024

@fuchenxi

pod 'HWPanModal', :git => 'https://github.com/HeathWang/HWPanModal.git'

我提交了,你看下能满足你的要求吗?没问题再发release

from hwpanmodal.

fuchenxi avatar fuchenxi commented on May 28, 2024

好的,我这两天忙完这个需求,我再测试下。完事告诉你

from hwpanmodal.

fuchenxi avatar fuchenxi commented on May 28, 2024

@HeathWang
四个手势全都抛出来了,是可行的。

之前的问题是模态出一个VC,里面嵌套一个横向滚动的CollectionView,会出现既可横向滚动CollectionView,也能纵向滚动Dimiss VC,主要是由于以下代码导致两个手势都可以识别。

目前我看是添加个协议HWPanModalPanGestureDelegate,只要实现协议的方法,直接就return了。我不用做什么事情,默认就是我想要的功能。

HWPanModalPresentableHandler.m
/**
 * ONLY When otherGestureRecognizer is panGestureRecognizer, and target gestureRecognizer is panGestureRecognizer, return YES.
 */
- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer {
    if ([gestureRecognizer isKindOfClass:UIPanGestureRecognizer.class]) {
        return [otherGestureRecognizer isKindOfClass:UIPanGestureRecognizer.class];
    }
    return NO;
}

from hwpanmodal.

HeathWang avatar HeathWang commented on May 28, 2024

ok,那我发布新version

from hwpanmodal.

HeathWang avatar HeathWang commented on May 28, 2024

@fuchenxi
指定版本:0.9.5

from hwpanmodal.

fuchenxi avatar fuchenxi commented on May 28, 2024

好的。我更新一下

from hwpanmodal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.