Giter Site home page Giter Site logo

Comments (6)

hedefalk avatar hedefalk commented on June 2, 2024

Well, aren't ; syntax error in old sass? I'm not expert, only used less and scss (sass2).

Look here:

https://github.com/hedefalk/atom-vue/blob/master/grammars/vue.cson#L158
vs
https://github.com/hedefalk/atom-vue/blob/master/grammars/vue.cson#L187

from atom-vue.

hedefalk avatar hedefalk commented on June 2, 2024

Sorry, Sass 3 that is.

from atom-vue.

ShayDavidson avatar ShayDavidson commented on June 2, 2024

Well, yes, but:

  • when the lang is sass, the new syntax (with semicolons) is compiled, but Atom shows a syntax error on the semicolons.
  • when the lang is scss, Atom doesn't show any syntax error for the semicolon, but vue/webpack can't find a scss-loader module for compilation.

(using webpack and vue-loader for compilation).
Maybe it's a config problem on my side, but I can't seem to fix it.
Anyway, I now realize this is not an issue with your package, hence closing it.

from atom-vue.

hedefalk avatar hedefalk commented on June 2, 2024

I'm successfully using webpack with

{ test: /.scss$/, loader: "style!css!sass" },

in webpack.config.js

and

"sass-loader": "~2.0.1",
"css-loader": "~0.17.0",
"style-loader": "~0.12.3",

in package.json -> devDependencies

Oh, wait, maybe I'm not… I'm not actually using any styling in my components there, seems to be on the side…

Please consider PR if you find any solution. This package was just something I auto-created for my own use mechanically (with a script) from the sublime one: https://github.com/vuejs/vue-syntax-highlight at a particular commit: vuejs/vue-syntax-highlight@4796727

Any work there by @yyx990803 et al hasn't been merged in here since.

from atom-vue.

hedefalk avatar hedefalk commented on June 2, 2024

I'm not sure, but I would guess that https://github.com/vuejs/vue-loader simply delegates to a matching loader. So if you write lang=scss in your .vue to make this atom plugin happy, you need to have:

{ test: /.scss$/, loader: "style!css!sass" },

and not

{ test: /.sass$/, loader: "style!css!sass" },

in your webpack config. Can this be the issue?

from atom-vue.

aidistan avatar aidistan commented on June 2, 2024

Please try the workaround @ShayDavidson

from atom-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.