Comments (4)
The right place to add this would be the ./public/css/slide-preview.css and we would really welcome every improvement there.
There is definitely no more particular reason that his hasn't been done yet, besides "lack of time/people who worked on it". If you need any help, feel free to reach out!
If you want to discuss things a bit more interactively, feel free to join our Matrix community channel at: https://riot.im/app/#/room/#codimd:matrix.org
from hedgedoc.
Ok, I've worked on this today and I fixed a bunch of things (styling of lists, hiding notes, removing border bottom for h1 and h2, making tables look similar to what they will look like in presentation mode etc.). For instance:
I haven't made a pull request yet because, when I merged my commits with upstream changes, I realized that the day and night modes now work differently than before. Namely, it used to be (and is still the case on demo.codimd.org) that the background-color of the view area for slides (as opposed to regular markdown files) is always black, in both day and night modes, as the above image shows.
Now, the background-color of the view areas for slides is affected by the day and night modes. As a result, you can no longer see separate slides in day mode (because they're white on white):
I just wanted to check whether this change was intended or not. If yes, I guess I can add borders to slides in day mode, although I don't think that will look as good as white slides against a black background.
from hedgedoc.
Nice, that looks really good already 👍 Ĺooking forward to see the changes as PR ^^
The changes done by day/night mode are definitely not intended. I don't mind if you consider fixing this too much work, but if you want to fix that, I'll definitely welcome it and get things merged.
from hedgedoc.
Should already be fixed with #93
from hedgedoc.
Related Issues (20)
- plotting mathematical functions with `gnuplot` code block extension HOT 1
- "Note not found" page not readable with light theme
- Re-add user-friendly error pages
- Hedgedoc 2 alpha: endless memory leak in the editor reproducible under Firefox HOT 2
- Dev Setup is not working on HTTP HOT 2
- Firefox Favicon changes randomly on refresh HOT 1
- running ./bin/setup failed: meta-marked: The remote archive doesn't match the expected checksum HOT 2
- Heroku build error: Couldn't find the node_modules state file
- Server crash when hedgedoc container infrastructure is missing avx cpu flag with "Illegal instruction" HOT 5
- Add error message when upload limit applies
- Azure Activate Directory setup documentation is invalid HOT 2
- Prevent Problem with colons for e.g. list introductions HOT 1
- LaTeX Display Mode Breaks Syntax Highlighting HOT 1
- Can't register a new user on https://pad.cas.cat/ HOT 3
- Redirect error on alpha2 container setup HOT 2
- Allow the upload of WebM animations
- hedgedoc2 upload image permission denied , frontend reject request
- Untitled document HOT 1
- :::spoil markdown extension (existing on CodiMD) HOT 2
- Upgrade sequelize to newer version in v1.9.9 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hedgedoc.