Giter Site home page Giter Site logo

Comments (4)

SISheogorath avatar SISheogorath commented on May 12, 2024

The right place to add this would be the ./public/css/slide-preview.css and we would really welcome every improvement there.

There is definitely no more particular reason that his hasn't been done yet, besides "lack of time/people who worked on it". If you need any help, feel free to reach out!

If you want to discuss things a bit more interactively, feel free to join our Matrix community channel at: https://riot.im/app/#/room/#codimd:matrix.org

from hedgedoc.

ttasovac avatar ttasovac commented on May 12, 2024

Ok, I've worked on this today and I fixed a bunch of things (styling of lists, hiding notes, removing border bottom for h1 and h2, making tables look similar to what they will look like in presentation mode etc.). For instance:

Скриншот 2019-05-26 16 53 15

I haven't made a pull request yet because, when I merged my commits with upstream changes, I realized that the day and night modes now work differently than before. Namely, it used to be (and is still the case on demo.codimd.org) that the background-color of the view area for slides (as opposed to regular markdown files) is always black, in both day and night modes, as the above image shows.

Now, the background-color of the view areas for slides is affected by the day and night modes. As a result, you can no longer see separate slides in day mode (because they're white on white):

Скриншот 2019-05-26 17 09 10

I just wanted to check whether this change was intended or not. If yes, I guess I can add borders to slides in day mode, although I don't think that will look as good as white slides against a black background.

from hedgedoc.

SISheogorath avatar SISheogorath commented on May 12, 2024

Nice, that looks really good already 👍 Ĺooking forward to see the changes as PR ^^

The changes done by day/night mode are definitely not intended. I don't mind if you consider fixing this too much work, but if you want to fix that, I'll definitely welcome it and get things merged.

from hedgedoc.

davidmehren avatar davidmehren commented on May 12, 2024

Should already be fixed with #93

from hedgedoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.