sysroot handling is wrong in certain cases

[alkis]

sysroot handling is wrong in certain cases

[cpsauer]

Hi again, Alkis! It's great to hear from you. Tool otherwise working okay for you guys at Databricks?

Definitely want to check with you, but I think that's working as originally intended (though my comment is at best ambiguous....)--though it's well possible that my original intent was wrong. Is it causing downstream errors?

The reason it's using the -isysroot<dir> form is that that's the only one documented by clang.

I'll go ahead and disambiguate the comment at the very least. It's possible clangd has fixed the underlying bug there... I'll check in on #84, but if you're using GCC, could I ask you to try removing that patch line and see if all still works successfully?

[alkis]

The tool is working great at Databricks. Thank you Chris!

We are using clang. Regarding sysroot support in clang, I am not an expert but --sysroot seems to be the right way to do it according to https://clang.llvm.org/docs/CrossCompilation.html. Also --sysroot is documented in the documentation linked above https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-sysroot, so perhaps we are fighting an old bug here? Maybe we should remove the code?

In any case the current code generates -isysrootXXXX. That is no space or = between flag and value. That seems wrong, no?

[cpsauer]

Yay! Delighted to hear it :)

@eschumacher-s confirmed over in #82 (comment) that the underlying clangd bug seems to be resolved, so I'll go ahead and remove the workaround.

[That said, I still think this was working right? Bug was in clangd, not clang. -isysrootXXXX was indeed the documented form, as above. sysroot and isysroot are quite similar.]