Not working on Eclipse 4.3.1

[gustiando]

Not working on Eclipse 4.3.1

[rowlo]

Just checked via Debugger. It appears the ParameterizedCommand.generateCombinations(Command) call has changed. Mousefeed is calling it in GlobalSelectionListener line 252.
That is original code and the comment states that only ParameterizedCommands are listed in the keys preference page. Obviously that is not true any more as the Preferences command is listed.

Further investigation:
GlobalSelectionListener#247: calls commandService.getCommand(actionId)
The call leads to CommandManager#548: Command command = (Command) handleObjectsById.get(commandId);
However, the returned Command is not defined. The Command class inherits from HandleObject which has a protected "defined" attribute. The value is false. Because of that value being false GlobalSelectionListener#252 throws a NotDefinedException.
It looks like a bug in Eclipse, because the command should be defined if you're able to use (execute) it.

[gustiando]

I issued a bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=419365 would you mind adding more comments if you think it's necessary? thanks!

[rowlo]

So, I've looked at all Eclipse versions 4.2.0 through 4.3.1 (64bit, linux). The Mousefeed version from this github repository works with all of them. The only feature working only partially is suggesting to setup a shortcut for often used actions/commands. (E.g., it works for the File|Import action.)

I've implemented it for 3.7.2 and it relies on the fact that commands, that are resolved for actions, are defined. That is true for many, some however are not. One example is the Window|Preferences action from the menu. In 3.7.2 clicking that action 2 times will increase the threshold counter. On the third click mousefeed would pop up a suggestion to setup a shortcut. When clicking that link you'd be taken to the keys preference page. Up to 3.7.2 the preferences actions was resolved to a defined command. Starting with 4.2.0 the resolved command is defined=false.

I'm not sure how to deal with that now. An option might be to have a look how the keys preference page aggregates it's list of commands and then just jump to the first matching the action's name. I might go for that some day.

Can someone verify, that Mousefeed is still working (Do you see the popups?) with Eclipse 4.3.1 on Mac and Windows? If so, I'd rather close this issue without changing any code.

[gustiando]

Hi! apparently it doesn't work for me, I'm on Mac OS 10.8.5
Eclipse
Version: 4.3.1
Build id: M20130911-1000

[gustiando]

OK nvm, I think Mousefeed is working, just saw a popup! I guess I was trying the wrong stuff, for example: closing a file, shouldn't it warn me to do COMMAND + W ?

[rowlo]

Not necessarily. Mousefeed can only provide popups for commands and for some actions. If the 'x' to close the window is resolved to a command with defined=false then Mousefeed cannot process it.

[gustiando]

makes sense. case closed then! thank you very much for your support!