Our pages include as a tag <div id="socialshare"></d

Just pushed a change that renames _Shariff to <code c

Shariff class not callable lately about shariff HOT 9 CLOSED

heiseonline commented on September 27, 2024

Shariff class not callable lately

from shariff.

Comments (9)

pmb0 commented on September 27, 2024

Let me see if I understood your question. You replaced the old socialshare-privacy code with Shariff.

The socialshare-privacy documentation recommended using the script tag inside the <head> of your document.

In contrast to that, Shariff must be included right before the (closing) </body> tag to work. Have you followed that instruction?

from shariff.

neffets commented on September 27, 2024

Yes,
if I would have an <div class="shariff"></div> it would work that way.
My problem is,

that the html-code has no class="shariff", i have an id=socialshare
I want enable the Share-Buttons later, not at body-end, but only after dom-ready

Solution could be:

on dom-ready I add with javascript the class=shariff to my div-with-id
Now comes problem 2
dom-ready ist later then body-end, I now want to trigger the shariff-code later, or better I want to give my $('#socialshare') as object to Shariff to paint the share-buttons there

from shariff.

pmb0 commented on September 27, 2024

Embedding Shariff is difficult in your situation (not a node project, no .shariff element).

Try something like this:

<head>
$(function() {
    $("#socialshare").addClass("shariff");
    $.getScript("/path/to/shariff.js");
});
</head>

In my opinion modifying the HTML document is the best option.

from shariff.

leegladding commented on September 27, 2024

We had a problem using this too recently. Our project was also not a node project.

We had need to initialize the shariff code after it was loaded on to the page, to allow for later ajax'd content to include the sharing functionality. The way we fixed this was to assign the _Shariff function to the window object. This allowed us to call as and when we needed.

Is this something you could add to this project to allow the plugin to be used in this way as well?

from shariff.

pmb0 commented on September 27, 2024

Just pushed a change that renames _Shariff to Shariff and that exports the Shariff class to the global (window) object:

27cd300#diff-f9e06b21d8f4ff0e3fd8301ee954ec47R236

This example html page shows how to initialize shariff after it was loaded:

https://github.com/heiseonline/shariff/blob/master/demo/custom-initialization.html

The change is not released yet.

from shariff.

leegladding commented on September 27, 2024

Looks great. Any idea when this might be released?

from shariff.

pmb0 commented on September 27, 2024

Today or tomorrow.

from shariff.

leegladding commented on September 27, 2024

Perfect. Thanks for the update.

from shariff.

pmb0 commented on September 27, 2024

Just released v1.9.1.

from shariff.

Shariff class not callable lately about shariff HOT 9 CLOSED

Comments (9)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent