Giter Site home page Giter Site logo

Comments (5)

pmb0 avatar pmb0 commented on September 27, 2024

Just released v1.12.0. Now you are able to use data-mail-subject and data-mail-body to customize the mail. Defaults are current page's title (subject) and current page's url (body).

from shariff.

Williwurstig avatar Williwurstig commented on September 27, 2024

data-mail-subject doesn't seem to work. Module uses always data-title.

from shariff.

richard67 avatar richard67 commented on September 27, 2024

@Williwurstig Note that according to the readme docs, data-mail-subject and data-mail-bodyare only used if the data-mail-url is a mailto: link, i.e. starts with mailto:. Is that the case in your situation?

from shariff.

Williwurstig avatar Williwurstig commented on September 27, 2024

Yes, the mailto: is there, but empty:
<div class="myshariff" data-mail-body="Link: {url}" data-mail-subject="This is the subject" data-mail-url="mailto:">
output:
<a href="mailto:?subject=Pagetitle&amp;body=Link%3A%0Ahttp%3A%2F%2Ftestdomain.de" title="Per E-Mail versenden" role="button" aria-label="Per E-Mail versenden"><span class="fa fa-envelope"></span><span class="share_text">mail</span></a>

Can anybody confirm this?

from shariff.

richard67 avatar richard67 commented on September 27, 2024

@Williwurstig I can confirm that.

I've tested and checked the source code, too. It seems that either the readme docs are not up to date, or the functionality is not implemented by mistake, because the option "data-mail-subject" is not used at all in the code.

Can you open a new issue for this here? I think developers don't get notified about comments on closed issues.

from shariff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.