Giter Site home page Giter Site logo

shx causes tests to fail about vddl HOT 4 CLOSED

awulkan avatar awulkan commented on June 15, 2024
shx causes tests to fail

from vddl.

Comments (4)

hejianxian avatar hejianxian commented on June 15, 2024

@awulkan Thank you for your PR.

Then, about this bug, I think shx must be installed as 'dependencies'.

"dependencies": {
    "lodash": "^4.16.4",
    "shx": "^0.2.2",
    "vue": "^2.4.2"
  },

I tried and it work.

from vddl.

awulkan avatar awulkan commented on June 15, 2024

Okey, great.
On their github page they tell people to install it as a dev dependency: https://github.com/shelljs/shx
But if installing it as a "normal" dependency makes it work then I see no problems with it.

Will you push that change?

from vddl.

hejianxian avatar hejianxian commented on June 15, 2024

@awulkan

Ing, but I will remove the shx. Because I don't want it appear in dependencies.

Sorry, for your previous PR. 😞

from vddl.

awulkan avatar awulkan commented on June 15, 2024

Ok, no worries. :)
Do you plan on replacing it with any other cross platform alternative?

Edit: Oh I see that you made it into a JS file, does it work on Windows?

from vddl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.