Internal transitions in nested state seems to trigger multiple actions

[hekailiang]

Internal transitions in nested state seems to trigger multiple actions

[hrosa]

@hekailiang I'm willing to contribute with a patch for this issue. Since I'm unfamiliar with code at the moment, could you provide any hints for me to get started?

[hekailiang]

go head, pass all the unit test

[hrosa]

@hekailiang any hints on where I should start looking?

[hrosa]

@hekailiang Was able to find the problem.

This line here https://github.com/hekailiang/squirrel/blob/master/squirrel-foundation/src/main/java/org/squirrelframework/foundation/fsm/impl/StateImpl.java#L390 can create duplicate transitions in the sub-state.

In the following example from debugger we clearly see two duplicate COLLECTING sub-states:

I'm planning to avoiding duplication of entries here: https://github.com/hekailiang/squirrel/blob/master/squirrel-foundation/src/main/java/org/squirrelframework/foundation/fsm/impl/StateMachineDataImpl.java#L174

&& !parallelStatesStore.containsEntry(parentStateId, subStateId)

Does this seem correct to you? Test suite is passing and this solves my issue.

[hrosa]

Created PR