Issues with `pyls`

[tuxiqae]

Issues with `pyls`

[archseer]

It looks like you have pyls installed and it's failing to communicate with it (can't find the Content-Length header).

Do you have a sample project I could test on?

[tuxiqae]

You may try testing on my WIP project https://github.com/tuxiqae/Friecipe

Or any other Python project TBH

[tuxiqae]

P.S. Seems like pyls really isn't working

 ❯ pyls
Traceback (most recent call last):
  File "/home/user/.local/bin/pyls", line 5, in <module>
    from pyls.__main__ import main
ModuleNotFoundError: No module named 'pyls'

[IceDragon200]

So this is a language server integration issue, I was able to navigate your project without issue, but I don't have pyls at all, so that may have helped.

I think the editor should probably show an error, saying it couldn't start/communicate with the language server and just disables it to prevent crashing unexpectedly

[archseer]

Reopening because I'd still like to solve the underlying cause, but at least it shouldn't panic anymore

[malte-v]

I don't think this is specific to pyls. I frequently get random crashes with rust-analyzer, too.

[malte-v]

Some debug logging reveals that language servers may sometimes send ill-formed messages:

2021-06-18T19:11:50.957 helix_lsp::transport [INFO] header: Content-Length: 111
2021-06-18T19:11:50.957 helix_lsp::transport [INFO] header: 
2021-06-18T19:11:50.957 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":142,"method":"window/workDoneProgress/create","params":{"token":"rustAnalyzer/Indexing"}}
2021-06-18T19:11:50.957 helix_lsp::transport [INFO] header: Content-Length: 141
2021-06-18T19:11:50.957 helix_lsp::transport [INFO] header: 
2021-06-18T19:11:50.957 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","method":"$/progress","params":{"token":"rustAnalyzer/Indexing","value":{"kind":"begin","title":"Indexing","percentage":0}}}
2021-06-18T19:11:50.961 helix_lsp::transport [INFO] header: Content-Length: 157
2021-06-18T19:11:50.961 helix_lsp::transport [INFO] header: 
2021-06-18T19:11:50.961 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","result":null,"id":142}
2021-06-18T19:11:50.961 helix_lsp::transport [INFO] header: {"jsonrpc":"2.0","method":"$/progress","params":{"token":"rustAnalyzer/Indexing","value":{"kind":"report","message":"40/523 (tokio_macros)","percentage":7}}}Content-Length: 156
2021-06-18T19:11:50.961 helix_lsp::transport [INFO] header: 
<crash happened here>

Notice that the last message does not look right at all.

[malte-v]

#306 should fix this issue. (I think the pyls error is also caused by the content_length unwrap.)