Comments (8)
Right on. The ropey maintainer(s) agreed to accept the api extension, I'm waiting for them to review the initial implementation. I'll @ mention you if/when it gets pulled into master.
from helix.
Thanks. It looks like the remaining ones are d, d
, i, a, esc, b, w
and i, a, esc, b, e
. If the ropey maintainers are interested in having an api extension that doesn't panic, I'll see about adding one.
from helix.
I think I addressed some of these in the latest push, it's mostly of by one errors or missing bounds checks -- I agree that having a safe indexing wrapper would be useful as well.
from helix.
After f4560cb just dd
left :)
from helix.
Fantastic! Just came to report this (with backtrace) but delighted to see it will be fixed upstream.
from helix.
Re: non-panicking version of Ropey's functions
@ammkrn and I have been discussing this in cessen/ropey#39. @archseer: if you could join the discussion over there, as the primary author of Helix, I'd really appreciate it!
from helix.
I believe the issue with dd
was fixed with #90.
from helix.
@jbaa Seems like it to me. Since the ropey api discussion is happening there, I'll go ahead and close this. Thanks!
from helix.
Related Issues (20)
- Emoji rendering issue HOT 1
- Syntax highlighting occasionally vanishes when selecting an lsp code suggestion HOT 1
- Remove escaping on shell commands HOT 2
- tree HOT 1
- hidden popup items after (Improve popup position #10257)
- Introduce an `auto-info-timeout` configuration parameter HOT 1
- Using LSP to rename could store history HOT 1
- Modify matching behavior when it fails to find the matching character HOT 1
- Consider if default theme should have different cursor colors for insert and normal mode HOT 2
- Tracking issue for popup HOT 3
- Toggling comments inside insert mode HOT 1
- Completion menu does not close when pressing up or down arrow keys HOT 1
- The cursor is indistinguishable between input mode and insert mode HOT 2
- Add syntax highlighting for the ignore file list from IntelliJ's `.ignore` plugin HOT 2
- Intrusive popups in `INSERT` mode HOT 1
- Python syntax highlighting missing some cases HOT 3
- Helix panicked HOT 1
- Support for registerCapability for formatting and rangeFormatting HOT 3
- Implementing <n>g HOT 1
- Add .http file syntax highlighting HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helix.