Giter Site home page Giter Site logo

List of mwes that panic about helix HOT 8 CLOSED

ammkrn avatar ammkrn commented on May 4, 2024
List of mwes that panic

from helix.

Comments (8)

ammkrn avatar ammkrn commented on May 4, 2024 2

Right on. The ropey maintainer(s) agreed to accept the api extension, I'm waiting for them to review the initial implementation. I'll @ mention you if/when it gets pulled into master.

from helix.

ammkrn avatar ammkrn commented on May 4, 2024 1

Thanks. It looks like the remaining ones are d, d, i, a, esc, b, w and i, a, esc, b, e. If the ropey maintainers are interested in having an api extension that doesn't panic, I'll see about adding one.

from helix.

archseer avatar archseer commented on May 4, 2024

I think I addressed some of these in the latest push, it's mostly of by one errors or missing bounds checks -- I agree that having a safe indexing wrapper would be useful as well.

from helix.

archseer avatar archseer commented on May 4, 2024

After f4560cb just dd left :)

from helix.

heliostatic avatar heliostatic commented on May 4, 2024

Fantastic! Just came to report this (with backtrace) but delighted to see it will be fixed upstream.

from helix.

cessen avatar cessen commented on May 4, 2024

Re: non-panicking version of Ropey's functions

@ammkrn and I have been discussing this in cessen/ropey#39. @archseer: if you could join the discussion over there, as the primary author of Helix, I'd really appreciate it!

from helix.

jbaa avatar jbaa commented on May 4, 2024

I believe the issue with dd was fixed with #90.

from helix.

ammkrn avatar ammkrn commented on May 4, 2024

@jbaa Seems like it to me. Since the ropey api discussion is happening there, I'll go ahead and close this. Thanks!

from helix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.