Giter Site home page Giter Site logo

Comments (7)

kirawi avatar kirawi commented on June 9, 2024

This was mentioned in the comment I think:

modes do not exist per view and are global. This is intentional, it was different in the past and caused significant problems/bugs.

View is roughly equivalent to a buffer IIRC

from helix.

7ombie avatar 7ombie commented on June 9, 2024

I understand that modes are global, but the mode-indicator is per-window, and the indicator currently acts as though modes are per-window. The indicator disappears when its window loses focus.

It's not the modes (nor their global nature) that's the problem. It's the mode indicator, as a UI element.

from helix.

7ombie avatar 7ombie commented on June 9, 2024

I understand that modes are global...

To be fair, I should have said that I now understand that modes are global. I didn't really appreciate that when I opened #9876 (which was correctly rejected).


Thinking about this some more, the issue with the mode indicators seems to stem from the fact that the statusline is per-window, while the mode is global and the bufferline is (similarly) unified.

There's obviously a lot of benefit in retaining all of the current information about the buffers, available (as it is now) per-window (and this can only go in the statusline). However, the statusline could still be defined in terms of the overall state, without changing it very much in practice.

The main difference would be that the statusline would start with a single, unified mode indicator, followed by the information for each of the currently visible buffers, with each buffer's information spaced to left-align with the corresponding buffer above.

Note: Due to the mode indicator, the leftmost window would have the same amount of space (and information) as it does now, and any other windows would have half a dozen or more extra spaces (and no more information). The mode indicators are merged into one, and everything else slides left to realign.

Styles bound to ui.statusline and ui.statusline.inactive in the current themes could be reused to distinguish active-buffer-info from inactive-buffer-info (across the unified statusline).

from helix.

7ombie avatar 7ombie commented on June 9, 2024

You could even move the mode indicator to the bufferline (either top-left, immediately before the buffer-names, or top-right, on its own, at the very end of the bufferline), so the statusline always looks the same for each window.

from helix.

kirawi avatar kirawi commented on June 9, 2024

To be clear, closing issues is about maintaining an organized tracker rather than shutting the door on further conversation. We've had several closed issues where conversation continued for a while, and some that were reopened.

from helix.

7ombie avatar 7ombie commented on June 9, 2024

@kirawi - No worries. Do you think I should close this issue? I'm happy to, if it helps.

from helix.

7ombie avatar 7ombie commented on June 9, 2024

If we agree that the issue with the mode indicators stems from the fact that the statusline is per-window, and that this is worth trying to fix, the effect on the existing APIs (configuration and theming) would need considering quiet deeply. I think it could plausibly be achieved without breaking anything, but you'd have to carefully repurpose parts of the existing APIs to make it work.

If you want to move this to a discussion, maybe that'd be better?? Whatever's best.

from helix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.