.app bundles within mounted .zip archives are not recognized

[hellosystem]

.app bundles within mounted .zip archives are not recognized

[probonopd]

For the extracted one it correctly says:

probono: checkWhetherAppDirOrBundle "/home/user/Desktop/Falkon.app"
probono: AppDir/app bundle detected xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx /home/user/Desktop/Falkon.app
probono: Set different icon for AppDir/app bundle

For the mounted one it doesn't:

probono: checkWhetherAppDirOrBundle "/var/run/user/1001/_home_user_Desktop_Falkon_FreeBSD.zip/Falkon.app"

So the bug might be lingering somewhere in

Filer/libfm-qt/bundle.cpp

Lines 15 to 56 in 69149a3

	bool checkWhetherAppDirOrBundle(FmFileInfo* _info)
	{
	bool isAppDirOrBundle = false;
	if((fm_file_info_is_dir(_info) || fm_file_info_is_symlink(_info)) == false) {
	return(isAppDirOrBundle);
	}
	QString path = QString(fm_path_to_str(fm_file_info_get_path(_info)));
	qDebug() << "probono: checkWhetherAppDirOrBundle" << path.toUtf8();
	QFileInfo fileInfo = QFileInfo(path);
	QString nameWithoutSuffix = QFileInfo(fileInfo.completeBaseName()).fileName();
	// Check whether we have a GNUstep .app bundle
	if (path.toLower().endsWith(".app")) {
	// TODO: Before falling back to foo.app/foo, parse the Info-gnustep.plist/Info.plist and get the NSExecutable from there
	// as described in http://www.gnustep.org/resources/documentation/Developer/Gui/ProgrammingManual/AppKit_1.html
	QFile executableFile(path.toUtf8() + "/" + nameWithoutSuffix);
	if (executableFile.exists() && QFileInfo(executableFile).isExecutable()) {
	isAppDirOrBundle = true;
	}
	}
	// Check whether we have a macOS .app bundle
	if (path.toLower().endsWith(".app")) {
	QFile infoPlistFIle(path.toUtf8() + "/Contents/Info.plist");
	QFile resourcesDirectory(path.toUtf8() + "/Contents/Resources");
	if (infoPlistFIle.exists() && resourcesDirectory.exists()) {
	isAppDirOrBundle = true;
	}
	}
	// Check whether we have a ROX AppDir
	QFile appRunFile(path.toUtf8() + "/AppRun");
	if ((appRunFile.exists()) && QFileInfo(appRunFile).isExecutable()) {
	isAppDirOrBundle = true;
	}
	return(isAppDirOrBundle);
	}

or in

Filer/libfm-qt/foldermodelitem.cpp

Lines 34 to 46 in 69149a3

	bool isAppDirOrBundle = checkWhetherAppDirOrBundle(_info);
	icon = IconTheme::icon(fm_file_info_get_icon(_info));
	// probono: Set some things differently for AppDir/app bundle than for normal folder
	if(isAppDirOrBundle) {
	QString path = QString(fm_path_to_str(fm_file_info_get_path(info)));
	QFileInfo fileInfo = QFileInfo(path);
	QString nameWithoutSuffix = QFileInfo(fileInfo.completeBaseName()).fileName();
	qDebug("probono: AppDir/app bundle detected xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx " + path.toUtf8());

But where?

[probonopd]

Turns out that Qt QFile exists() seems to return false for files in mounted archives for whatever reason.

[probonopd]

QFile::exists((QFileInfo(...).canonicalFilePath())) works.

[probonopd]

Much better!