Dragging a mountpoint to the Trash should unmount/eject

[probonopd]

Dragging a mountpoint to the Trash should unmount/eject

[probonopd]

What shall happen if a combination of files, folders and mountpoints is dragged by the user to the Trash? (What happens on a Mac in this case)?

Dragging to the trash to eject

• If one removable volume is dragged, the icon for the Trash changes to an Eject icon
• If two or more removable item are dragged, the icon for the Trash changes to an Eject icon
• If one or more removable volumes plus at least one non-removable volume are dragged, then the icon for the Trash does not change to an Eject icon on the Mac and dragging those to the Trash does not do anything
• If one or more removable volumes plus at least one other object are dragged, then what is the right thing to do? (On the Mac, the icon for the Trash changes to an Eject icon but also will put the other object to the Trash which I find inconsistent)

Moving things to the Trash

• If one or more file/folders are selected, the context menu has an item Move to Trash. I think we should also have it in the File menu for consistency
• If one or more file/folders plus at least one other object (such as a Volume) are selected, there is no menu item Move to Trash

[probonopd]

Implemented in a simple form: If at least one of the items dragged to the trash is a mountpoint, then we try to unmount all dragged items. If someone wants to implement a more fancy form as described above, feel free to do it.

• 2836592 and subsequent commits