Giter Site home page Giter Site logo

Comments (14)

unguiculus avatar unguiculus commented on August 25, 2024 1

Thanks for reporting. I'll look into it. From what I've seen, Helm needs to be installed in the first place. This is an oversight because initial testing of the set of actions happened in one workflow and Helm was already there in that case.

from chart-releaser-action.

davidkarlsen avatar davidkarlsen commented on August 25, 2024 1

Ah - got it to work for testing - had forgotten to pass the config to the action.

from chart-releaser-action.

unguiculus avatar unguiculus commented on August 25, 2024

I looked into this. Installing Helm alone doesn't really solve this. We would also have to add chart repos for the dependencies. The question is whether this should be part of the chart-releaser action. It may be better to provide a separate action that installs Helm. That could be generally useful anyways. It probably would then look like this:

name: release

on:
  push:
    branches:
      - master

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v1

      - name: Configure Git
        run: |
          echo "GITHUB_ACTOR: $GITHUB_ACTOR"
          git config user.name "$GITHUB_ACTOR"
          git config user.email "[email protected]"

      - name: Install Helm
        uses: helm/[email protected]

      - name: Add Helm repos
        run: |
          helm repo add foo https://foo.helm.example.com
          helm repo add bar https://bar.helm.example.com

      - name: Run chart-releaser
        uses: helm/[email protected]
        env:
          CR_TOKEN: "${{ secrets.CR_TOKEN }}"

from chart-releaser-action.

davidkarlsen avatar davidkarlsen commented on August 25, 2024

Same for the chart-testing-action.
In the old action I used (a non-helm one) repos were added by defining them in the ct-config - maybe that could be done here too?: https://github.com/evryfs/helm-charts/blob/feature/mcrouter-bitnami-memcached/ct-config.yaml && evryfs/helm-charts@82799da

from chart-releaser-action.

scottrigby avatar scottrigby commented on August 25, 2024

Yep that works perfectly for the chart-testing-action 👍 It's a little more of a pain for chart-releaser-action, but it also works. Here's a test in the demo repo. WDYT? helm/charts-repo-actions-demo#7

from chart-releaser-action.

davidkarlsen avatar davidkarlsen commented on August 25, 2024

I think the old action I used where only configuration of ct-config.yaml was needed was more elegant - then you don't need to mess around with helm-download and configuration.

from chart-releaser-action.

davidkarlsen avatar davidkarlsen commented on August 25, 2024

The other one seems to automate dependency update: https://github.com/J12934/helm-gh-pages-action/blob/master/index.js#L68

from chart-releaser-action.

scottrigby avatar scottrigby commented on August 25, 2024

@davidkarlsen do you feel good about closing this issue? Or maybe we should clearly document this somewhere before closing

from chart-releaser-action.

davidkarlsen avatar davidkarlsen commented on August 25, 2024

Mmmm, it was never fixed? Chart-testing works as it seems to read the config-file. But last time I tested the releaser it failed.

from chart-releaser-action.

douglascamata avatar douglascamata commented on August 25, 2024

The releaser still fails with dependencies while my config file is in the repo: https://github.com/newrelic/helm-charts/runs/713817996

from chart-releaser-action.

torstenwalter avatar torstenwalter commented on August 25, 2024

There is a GitHub action to install helm https://github.com/Azure/setup-helm

from chart-releaser-action.

planetf1 avatar planetf1 commented on August 25, 2024

At a minimum it would be good if the docs were updated to explain how to handle charts with dependencies. I'm just experimenting with this action in https://github.com/odpi/egeria/issues/1514 and found the same issue ie, when I had my released charts posted to my new pages (nice thanks!):

$ helm install lab odpi-egeria-lab                                                                                          [11:06:57]
Error: found in Chart.yaml, but missing in charts/ directory: kafka

I got the same issue for an older chart (requirements.yaml) and newer (dependencies in Chart.yaml) - I'll look at the fragment above & aim to automate the repo add (and presumably dependency update)

from chart-releaser-action.

planetf1 avatar planetf1 commented on August 25, 2024

Apologies - user error. I had been using local paths rather than referring to my new repo. Dependencies now do seem to be handled correctly

from chart-releaser-action.

davidkarlsen avatar davidkarlsen commented on August 25, 2024

This works now, so closing.

from chart-releaser-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.