Comments (2)
mvhatch
commented on June 3, 2024
FWIW, I do not see labels dropped for non-custom resources; I tested the same steps above using a plain old k8s Service and the expected labels were present as expected
from helm.
gjenkins8
commented on June 3, 2024
Helm updates custom resources using an old style "json patch" method:
Line 642 in 15d116b
Originally, if my understanding of history and this code is correct, Helm was not able to support three-way stragetic merge patching on custom resources, as only native/build-in objects were supported. Which is (likely) why you see the difference between CRs and native objects (resources).
I believe that is not longer a limitation with newer Kubernetes libraries, but this code retains its behavior for compatibility reasons. Switching Helm to use SSA (server-side apply) would also improve Helm's support here.
from helm.
Related Issues (20)
- why don't helm pass --insecure-skip-tls-verify into plugin? HOT 2
- json schema validation technical challenges HOT 1
- Helm install --wait is not correct to pod HOT 1
- CVE's in Helm v3.14.3 about runc vulnerable HOT 3
- Proposal: New omitted function to set a default value if value omitted HOT 1
- Disallowing '-' in key names causes problems
- Helm 3.14.1+ flags charts as invalid due to validation error on chart.metadata.name HOT 1
- Missing docs on ownership annotations
- Compare new values.yaml and old values.yaml during helm upgrade HOT 1
- Docs: Add note for prerelease versions about invalid leading zeros HOT 4
- upgrade.RunWithContext fails if task is canceled through context, rather than proceeding in the background HOT 2
- Tests fail after 2024-06-07
- retrieving labels added to revision HOT 4
- Feature Request: Option to list Transitive Dependencies Values files
- helm install/upgrade/rollback --dry-run --debug
- OCI image annotation org.opencontainers.image.created should use timestamp of pushed TGZ instead of current time HOT 2
- Failure in pre-upgrade leads to crash of helm when rollbacking
- Helm upgrade states secret patching during upgrade. However, its behaviour is not matching with behaviour of kubectl patch command HOT 1
- helm lint and helm package fail to find a charts subdirectory HOT 1
- Chain of subcharts won't allow exported values to be at root level
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm.