Comments (2)
@wimnat looking at https://github.com/envoyproxy/gateway/releases/download/v1.0.1/install.yaml, it seems to contain multiple documents inside one YAML file i.e parts split with ---\n
. Some of the documents contain comments starting with # Source: ...
Here is an output after running helm template
#
# Gateway API Experimental channel install
#
---
# Source: foo/templates/install.yaml
# Source: gateway-helm/crds/generated/gateway.envoyproxy.io_backendtrafficpolicies.yaml
---
# Source: foo/templates/install.yaml
# Source: gateway-helm/crds/generated/gateway.envoyproxy.io_clienttrafficpolicies.yaml
---
# Source: foo/templates/install.yaml
# Source: gateway-helm/crds/generated/gateway.envoyproxy.io_envoypatchpolicies.yaml
---
# Source: foo/templates/install.yaml
# Source: gateway-helm/crds/generated/gateway.envoyproxy.io_envoyproxies.yaml
---
# Source: foo/templates/install.yaml
# Source: gateway-helm/crds/generated/gateway.envoyproxy.io_securitypolicies.yaml
---
# Source: foo/templates/install.yaml
# Source: gateway-helm/templates/certgen-rbac.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
name: eg-gateway-helm-certgen
namespace: 'envoy-gateway-system'
labels:
helm.sh/chart: gateway-helm-v0.0.0-latest
My suggestion is that helm template should check for the yaml start document line ---\n prior to the comment addition and remove it if it exists so that the comment will always appear in the same document as the manifest it is rendering.
I'm not sure I follow your suggestion here. Specifically, what do you mean by will always appear in the same document as the manifest
? The YAML file in question contains multiple documents which helm renders as expected.
from helm.
closing as dup: #12953
(please comment if I'm mistaken)
from helm.
Related Issues (20)
- Helm version for v3.15.0 reports v3.15.0-rc.2 HOT 12
- Overriding Helm chart dependency version in parent chart HOT 2
- error converting YAML to JSON: did not find exected key HOT 1
- error converting YAML to JSON: yaml: line 22: did not find expected key HOT 7
- Update backward compatibility promise in CONTRIBUTING.md to reflect HIP 0004 HOT 3
- Helm Apt install/package is broken and can't be installed HOT 5
- OCI registry authentication: Some registries will require different auth for different URIs HOT 5
- How to instruct Helm not to add "managed-by" label to the STS HOT 2
- Make retryingRoundTripper type public HOT 1
- Unexpected HELM validation manifests behaviour HOT 1
- [Feature] Custom versioning support
- Helm Chart Dependency Versions in chart.lock Not Matching Specified Versions
- Helm doesn't report the right status of the job
- Is mapkubeapis plugin recommended for production by helm for manipulating release manifest ?
- Version 3.15.0 for linux-amd64 is not published. HOT 2
- binary from helm-v3.15.0-linux-amd64.tar.gz reports wrong version HOT 1
- json value gets merged when using custom values yaml file instead of overriding
- Use of Helm build-in objects in Helm templates inside JSON files
- Make funcMap public for unit testing syntax of templates
- The randAscii function returns an error after multiple --dry-run tests HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm.