Vulnerabilitites after npm install

[crashbdx]

Vulnerabilitites after npm install

[henrikhb]

Well yes the node_modules directory is ignored, however package.json specifies which npm packages to install. So the next person using this repo will not get all of the security warnings, since I pushed the updated package.json file after running npm audit fix.

[lucazambon]

This is a problem of npm, not of the repo. Try to run npm audit fix to fix it.

[crashbdx]

Will do thanks for the help :)

[henrikhb]

Hi there! I just ran npm audit fix in the repo as wel. It fixed all the vulnerabilities that could be fixed without breaking functionality. So some of the npm packages have been updated if you fetch the latest package.json.

[lucazambon]

It doesn’t matter because we will run npm install on installation. And node_modules is ignored by .gitignore and it’s correct like that.
Anyone should run npm audit fix on their machine.

[lucazambon]

Oh fine! Nice