ValueError when parsing QT_VERSION_STR

[fermino]

ValueError when parsing QT_VERSION_STR

[HenriWahl]

@jr-timme 👍 yes, done now in latest commit. Binaries shall be available soon. Thanks!

[HenriWahl]

@fermino well, Nagstamon here is only interested in the major version. The minor and bugfix versions are only catched there from the standard QT version string.

So it would be enough to grab just the major version, via something like

QT_VERSION_MAJOR = int(QT_VERSION_STR.split('.')[0])

Regarding a version selection variable I thing we should go the Qt6 way. The used variable already comes with Qt and it would make things more complex to use such a switch.

[WoutResseler]

Had the exact same issue, @HenriWahl 's solution does the trick for me for now.

[jr-timme]

I also ran into this Problem and am currently running Nagstamon with the change mentioned by @HenriWahl :

diff --git a/Nagstamon/QUI/qt.py b/Nagstamon/QUI/qt.py
index 3bc50c5b..50fb0886 100644
--- a/Nagstamon/QUI/qt.py
+++ b/Nagstamon/QUI/qt.py
@@ -28,7 +28,7 @@ try:
     from PyQt6.QtCore import PYQT_VERSION_STR as QT_VERSION_STR
 
     # get int-ed version parts
-    QT_VERSION_MAJOR, QT_VERSION_MINOR, QT_VERSION_BUGFIX = [int(x) for x in QT_VERSION_STR.split('.')]
+    QT_VERSION_MAJOR = int(QT_VERSION_STR.split('.')[0])
     # for later decision which differences have to be considered
     QT_FLAVOR = 'PyQt6'
 except ImportError:

I haven't found any problems yet.

So if there is no reason to include the Minor and Bugfix versions this could be merged?

[HenriWahl]

I fixed it in latest testing release 3.15-240417 - can you please try it?

[jr-timme]

I think one of the square brackets should be moved further back as we want to limit the output of the split function to the first two elements and not the output of the list comprehension?

>>> from PyQt6.QtCore import PYQT_VERSION_STR as QT_VERSION_STR

>>> [int(x) for x in QT_VERSION_STR.split('.')][0:2]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 1, in <listcomp>
ValueError: invalid literal for int() with base 10: 'dev2404081550'

>>> [int(x) for x in QT_VERSION_STR.split('.')[0:2]]
[6, 7]

or did I misunderstand the intent of the change?

I'm not sure if the Version Number always is the way it is now but if it is, we could also keep the Patch version if we limit the array to the first 3 elements:

>>> QT_VERSION_STR.split('.')
['6', '7', '0', 'dev2404081550']
>>> [int(x) for x in QT_VERSION_STR.split('.')[0:3]]
[6, 7, 0]

edit: that also seems to be the workaround the AUR nagstamon-git package maintainer chose:

+  sed -i Nagstamon/QUI/qt.py -e "s/QT_VERSION_STR.split('.')/QT_VERSION_STR.split('.')[0:3]/"

https://aur.archlinux.org/cgit/aur.git/commit/?h=nagstamon-git&id=654ecd9de51e2ab0213bb39d2b1e1cbe226ac397

[HenriWahl]

@jr-timme Nagstamon only needs the major and the minor version part, so it is ok to ignore the bugfix level.

[jr-timme]

Ok, so then only the square bracket should be moved further back to prevent the list comprehension from still trying to cast dev2404081550 into an integer