Giter Site home page Giter Site logo

Comments (5)

HenriWahl avatar HenriWahl commented on May 20, 2024

Does it work without that escapes? Is the result the same with different browsers?

from nagstamon.

DoGauss avatar DoGauss commented on May 20, 2024

I've tested it with every browser at my disposal: IE10, FF22, Chrome 22, opera 12
they all work as I'd expect it: %0d%0a causes a new line in the mail body.

It seem as if nagstamon would prevent the correct parsing of the escape sequences.
If I had to make an educated guess, I'd say the complete action string get's URL encoded before execution and thus breaking the ability to use escape sequences - that would mean: no chance of having new lines in emails.

of course: creating emails this way without new lines works just fine

from nagstamon.

HenriWahl avatar HenriWahl commented on May 20, 2024

I played with your example and found it not working with &subject but ?subject.

Line 651-656 in Actions.py:

def _URLify(self, string):
    """
    return a string that fulfills requirements for URL
    exclude several chars
    """
    return urllib.quote(string, ":/=?&@")

So yes URLs get cleaned.

I tested Browser URLs without that _URLify() and it works as you expected. Obviously the browsers could URLify the URLS themselves and this method should not be needed here.

from nagstamon.

DoGauss avatar DoGauss commented on May 20, 2024

Thanks for clarifying.

nonetheless thanks for pointing out a syntactical error. the mailto protocol expects a question mark as separator between the first argument (most often the to field) and other arguments. additional parameters are linked with an ampersand.

from nagstamon.

HenriWahl avatar HenriWahl commented on May 20, 2024

I think your way to send emails should work in future version - next github commit to be exact.

from nagstamon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.