Giter Site home page Giter Site logo

Comments (13)

talbright avatar talbright commented on August 30, 2024 1

The ability to assign an owner exists now, but that version of the API is not marked stable. Once it is we can easily add this.

from terraform-provider-heroku.

davidji99 avatar davidji99 commented on August 30, 2024

This might be a limitation on the Heroku Platform API itself as https://devcenter.heroku.com/articles/platform-api-reference#pipeline doesn't have an option to specify the owner. Without API support, it might not be possible to do this via terraform.

from terraform-provider-heroku.

chdsbd avatar chdsbd commented on August 30, 2024

That's a shame. This issue should probably be tagged Heroku API Support.

from terraform-provider-heroku.

slykar avatar slykar commented on August 30, 2024

@talbright It has been some time since the introduction of the new API in Heroku CLI. Do you have any insight on when will it be more than a prototype?

The lack of this new functionality makes the Heroku provider quite useless for me right now. Maybe we could have "beta" version of the terraform Heroku provider?

Personally, I don't mind being on a cutting edge here, as I will have to script it with Heroku CLI, which is using this "unstable" API anyway.

I don't know historically how stable Heroku API is, but it might make sense to have an experimental fork of Heroku provider with all the bells and whistles. Those might be easily merged into the stable version as soon as the API is also marked as stable.

from terraform-provider-heroku.

talbright avatar talbright commented on August 30, 2024

There's a much stronger stand in the provider to follow a fairly strict policy of not adding support for variants or any feature that's not part of the public API. The use cases and support for the Heroku CLI are quite different than that of the provider.

We do use this provider for multiple internal projects, some of them large, so we understand the frustration this can cause. But we have to balance that against the significant disruptions an unstable provider can cause. I don't expect this stance to change anytime soon.

I will follow-up with some of the back-end engineers and find out where things are with updating the API to support pipeline ownership, and let you know.

from terraform-provider-heroku.

slykar avatar slykar commented on August 30, 2024

Thanks for the answer. I would love to get some follow up on this.

Of course, my previous answer was a bit exaggerated, but there is some frustration that comes with needing to do some things manually or not knowing if there are some other "hidden" properties that require manual action.

I understand the point about stability of the provider. I was thinking if maybe there is a community fork of the provider that has an explicit experimental stability and includes the newest, non-documented features.

In the meantime I'll try to workaround this problem using local-exec provisioners with cli.

from terraform-provider-heroku.

talbright avatar talbright commented on August 30, 2024

The answer I have from the team is that it is on the roadmap, but I don't have an exact ETA. I would suggest proceeding with using local-exec as a workaround, as you mentioned.

from terraform-provider-heroku.

davidji99 avatar davidji99 commented on August 30, 2024

I understand the point about stability of the provider. I was thinking if maybe there is a community fork of the provider that has an explicit experimental stability and includes the newest, non-documented features.

One can always fork and build the provider locally and/or on a CI tool (it's what my team does since we added some changes that might be too opinionated for the public provider). But for a forked heroku provider binary to be distributed by Hashicorp is another story and something that might need some insight from them.

from terraform-provider-heroku.

marlonjohnynion avatar marlonjohnynion commented on August 30, 2024

Do you guys have an update for this?

The answer I have from the team is that it is on the roadmap, but I don't have an exact ETA. I would suggest proceeding with using local-exec as a workaround, as you mentioned.

from terraform-provider-heroku.

dcherman avatar dcherman commented on August 30, 2024

Hey @talbright, is support for pipeline ownership still pending / in prototype? It's not clear from https://devcenter.heroku.com/articles/platform-api-reference#pipeline-create whether or not it's still in prototype or not. The example usage of that API includes an owner, but it's not explicitly listed as one of the supported params.

from terraform-provider-heroku.

davidji99 avatar davidji99 commented on August 30, 2024

I recently updated the heroku-go API client and PipelineCreateOpts still only has the name field as a parameter:

type PipelineCreateOpts struct {
	Name string `json:"name" url:"name,key"` // name of pipeline
}

The client is auto-generated from the Platform API schema so setting ownership is still not available when creating a pipeline.

@ninjaengineers & @dcherman, I suggest you submit support cases to Heroku indicating your desire for this enhancement. At the same time, Heroku support might be able to provide you with more information regarding the enhancement's status.

from terraform-provider-heroku.

mars avatar mars commented on August 30, 2024

@davidji99 it looks like you may be viewing an old version, because PipelineCreateOpts has an Owner field now 🎉
https://github.com/heroku/heroku-go/blob/v5.2.0/v5/heroku.go#L2978

Also documented in Platform API Reference: Pipeline Create

from terraform-provider-heroku.

davidji99 avatar davidji99 commented on August 30, 2024

Oh! I thought I was looking at latest master. Cool, this should be simple enough to add into the provider.

from terraform-provider-heroku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.