local.ERROR: Cannot redirect to an empty URL.

[herpaderpaldent]

local.ERROR: Cannot redirect to an empty URL.

[herpaderpaldent]

On my mobile but according to the errorstack its because of this line

seat-discourse/src/Http/Controllers/SsoController.php

Line 69 in 0d41ae1

return redirect()->away(env('DISCOURSE_URL'));

So the env variable seems to be empty ... are you using docker?

[flyingferret]

No we're not using a docker install, think this was caused when fixing issues with another plugin the command php artisan config:cache was run. But not sure on the repair, the .env file was untouched

[flyingferret]

Talking with other Devs have had the following conversation.

kalaik utama 12:14 PM
@warlof Tutsimo folllowing running the command php artisan config:cache it seems some of my env varibles have been cleared :S and broken my discourse plugin. Although the .env are untouched the line
return redirect()->away(env('DISCOURSE_URL'));
is returning null....eeep

Warlof Tutsimo 12:15 PM
env shouldn't be call outside config files
12:15
especially since once config is cached, env is non longer used 😛

kalaik utama 12:15 PM
rodger

Warlof Tutsimo 12:15 PM
php artisan config:clear will drop existing cached config
12:16
yeah
12:16
it's reason why it has been changed long time ago in SeAT 3

kalaik utama 12:16 PM
sorry to be a pain , just trying to get it back working for my alliance and pulling my hair out
12:17
so if i run config:clear we should be back to square one ?

Warlof Tutsimo 12:17 PM
https://laravel.com/docs/8.x/configuration#configuration-caching
12:18
yeah, since there we no more cached configuration, dotenv will always reload data from $_ENV and .env file (edited)

kalaik utama 12:18 PM
thank you will try that again now, and will put this note on the issue i have raised with that plugin

Warlof Tutsimo 12:19 PM
and for timeline, here is initial fix on web repo eveseat/web@e21361a
12:19
should also have a few in eveapi package and others

kalaik utama 12:19 PM
thanks pal

[herpaderpaldent]

Yeah fair, when i created the package 2 years ago i was fairly inexperienced so this one of these bugs.

Using the resource warlof gave you, you could write a PR which would fasten the development significantly.

[herpaderpaldent]

allright i got a fix: are you able to change your composer.json to require it?

herpaderpaldent/seat-discourse: "dev-fix/evn"

should do it. I have no application running to test it myself therefore before merging and tagging the fix i need you to confirm its working.