Multiple classes exported from different DTO files overwrite each other during generation

[hey-api]

Multiple classes exported from different DTO files overwrite each other during generation

[mrlubos]

@Stono just to confirm, do you know if this is also a problem in the original package?

[Stono]

I would believe so yes, as the location of the model generation hasn't changed

[mrlubos]

@Stono is naming important to you or would you be okay with names like Model, Model2? (append number if conflict) or would you prefer namespaces and having multiple imports, e.g. import type { Model } from 'client/foo/bar'?

[jordanshatford]

@Stono could you provide your openapi spec?

cc @mrlubos : this will become an issue now that we us 1 models file?

[Stono]

Can do when I'm back from my holidays next week :)

…

On Thu, 28 Mar 2024, 17:58 Jordan Shatford, ***@***.***> wrote: @Stono <https://github.com/Stono> could you provide your openapi spec? cc @mrlubos <https://github.com/mrlubos> : this will become an issue now that we us 1 models file? — Reply to this email directly, view it on GitHub <#42 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALK7CPUCCRW6JH6NKZI7L3Y2PLTFAVCNFSM6AAAAABEQPWQ7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUG4YDGOBWGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mrlubos]

@jordanshatford the issue existed prior to having a single file and continues to exist with that change, it had no impact on this issue

[mrlubos]

@Stono bump

[jordanshatford]

@mrlubos this ticket has gone stale. It's been 20 days. We likely close this and new one can be opened if needed

[Stono]

Hey chaps I've been in Japan but I'm back now... Give me a few days get back going!

…

On Wed, 17 Apr 2024, 07:15 Jordan Shatford, ***@***.***> wrote: @mrlubos <https://github.com/mrlubos> this ticket has gone stale. It's been 20 days. We likely close this and new one can be opened if needed — Reply to this email directly, view it on GitHub <#42 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALK7CKKIPMLALTVEGY3RXDY5YHQZAVCNFSM6AAAAABEQPWQ7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGQ2TOMRQGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mrlubos]

Little flex @Stono 😂 okay, whenever you have time, would like to understand what's the correct solution for this

[Stono]

Haha yeah little flex, was awesome.

I actually think my issue is with nestjs's swagger generation; i'm going to raise an issue on their repo and crosslink here so you can have a read.

I don't think there's anything this project can do as you're just acting on the swagger which is generated by nest and subsequently invalid, so feel free to close the issue!

[Stono]

Unfortunately I can't use this library any more anyway because of the ESM dependency :-(

[jordanshatford]

@Stono we do plan to support both ESM and CommonJS. I am looking into it and hope to have both supported soon

[jordanshatford]

ref: #409 to support commonjs again

[mrlubos]

@Stono All good now?