Wrong infered content type for excel documents

[tadejsv]

Wrong infered content type for excel documents

[mrlubos]

Risky change of the day will be changing the type for blob into application/ 🤞

[mrlubos]

@tadejsv I will release a proper fix for this, maybe tomorrow?

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• hey-api-client-fetch-example (Open reproduction)

[tormodAase]

I don't think it would be correct to assume that all vendor media types should be parsed as binary. Vendor media types has many different formats:
https://www.iana.org/assignments/media-types/media-types.xhtml#application

If you need a quickfix to your specific issue, perhaps you could create a response interceptor?

client.interceptors.response.use(async (response) => {
    if (response.headers.get("Content-Type")?.includes("application/vnd")) {
        response.headers.set("Content-Type", "application/zip");
    }
    return response;
})

[tadejsv]

Hm, from the list you sent it seems a lot of formats have +json in their name to signal they are JSON - perhaps a better default would be to assume we have binary unless there is +json? And in general, I think 90% of the formats there are bonary, so treating then as sich would be a better default than json

In any case, will try your proposed solution, thanks.

[tadejsv]

@tormodAase unfortunately your fix does not work, as headers are immutable

[tadejsv]

@mrlubos I think a long term solution would be enabling the user to provide custom mapping between content types and different types of parsing :)

[mrlubos]

You can always specify manually which one you'd like by configuring the service/client call by passing parseAs, but yes that could be also a consideration

[tadejsv]

@mrlubos oh thanks, I was not aware of this option! This solves my problem

[mrlubos]

@tadejsv I assume the correct setting would be blob in this case?

[tadejsv]

Yes

[mrlubos]

I linked a fix, but might wait with publishing it for a few days. I am quite positive it will break application/x-www-form-urlencoded so need to handle that too

[mrlubos]

@tadejsv in the meantime, you can manually remove the header by passing headers to the call/client/wherever necessary

{
  'Content-Type': null, // <-- this will clear the header
}