Transformed Date(s) in query ends up as empty string(s)

[AndreasJJ]

Transformed Date(s) in query ends up as empty string(s)

[Nick-Lucas]

This strikes me as more of a client bug. When you pass a Date to a body, it gets serialised to an ISO string automatically by every client I've used.

It looks like the createQuerySerializer needs updating to identify Date and call .toISOString() on it

openapi-ts/packages/client-fetch/src/utils.ts

Line 261 in 37a991a

export const createQuerySerializer = <T = unknown>({

[AndreasJJ]

Thanks for the quick fix, it works for us now.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• hey-api-client-fetch-example-ujvl7y (Open reproduction)

[mrlubos]

@Nick-Lucas do you think we should add request transformers? Or not allow passing Date(s) into requests and require users to transform them into strings?

[AndreasJJ]

@mrlubos I updated @hey-api/openapi-ts to ^0.52.3 and @hey-api/client-fetch to ^0.2.2, but the resulting request url is now on the format https://test.com/test?2024-08-03T21:59:59.999Z&2024-08-10T21:59:59.999Z. So it's correctly serializing the date to a string now, but it's not including the query parameter name.

[mrlubos]

@AndreasJJ Ugh. This is with the example above? I'll check, sorry for that

[mrlubos]

@AndreasJJ I am not sure which path I tested the last time, but the new fix works with your example. Will fix whatever it might be breaking if that's the case