heyputer/kv.js

⚡️ Advanced in-memory caching for JavaScript.

kv.js's Issues

Create Typescript typings

NPM packages nowadays are developed using Typescript and type definitions are exported from the library so that methods and classes are typed. Since this library is entirely written in javascript, one of the following two can be picked to provide type definitions:

1. Convert the library to typescript and export interfaces
2. Submit type definitions to definitely typed repository so that consumers can add optional typings using npm install -D @types/heyputer__kvjs

Personally, and I believe most others as well, would like to see no. 1 picked and this library converted into a typescript one.

Expire with NX option

Saw your project on https://news.ycombinator.com/item?id=35608601 and the expires command seems wrong

kv.js/README.md

Lines 119 to 120 in 596ba10

	// Set a key's time to live in seconds only if the key does not exist
	kv.expire('username', 120, 'NX');

Shouldn't kv.expire('username', 120, 'NX'); mean "Set expirity of username to 60 seconds if it has no expirity"? The documentation suggests "Set expirity of username to 60 seconds if username does not exist" which makes no sense (as the key does not exist and thus can't have expirity).

See redis docs for reference/suggestion https://redis.io/commands/expire/

cleanupLoop

https://github.com/HeyPuter/kv.js/blob/main/kv.js#L2912

I think you mean to refence this.cleanupInterval?

Also, using a timer to cleanup expired keys is really inefficient and a huge performance suck--especially for a lot of ttl keys. I suggest at least making it optional, if not removing it entirely.

i did not understand the usage

hello.
what is the use of this lib? i didn't understand properly.
(whats the difference between this and a simple value/variable in js?)