Comments (4)
It seems that GitHub determines the author according to the git blame of the cron line in the Github action flow
See https://github.com/orgs/community/discussions/25067
from hhast.
Thanks; if this isn't based on the token, the easiest ways to change it would be git config --global user.name FOO
and git config --global user.email FOO
or the GIT_AUTHOR_*
/GIT_COMMITTER_*
variables at https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables , as a guess, changing them to point to facebook-github-bot
It also might end up giving you more readable results to split out the update workflow from the main testing workflow
from hhast.
Ok, it looks like @Atry is likely right. Ignoring the issues with thatβ¦
We should probably pass an explicit author in these 2 cases. Not sure if it makes sense to do that in all cases or just if it's a scheduled job. Either way, you want to pass author
in the with
arguments to the action being run there. cf. https://github.com/peter-evans/create-pull-request#action-inputs
- https://github.com/hhvm/hhast/blob/main/.github/workflows/build-and-test.yml#L69-L75
- https://github.com/hhvm/hhast/blob/main/.github/workflows/build-and-test.yml#L100-L108
I don't know if y'all have a bot you're using (hhvm-bot had some issues IIRC), so could just make it facebook-github-bot if you want. Facebook Community Bot <[email protected]>
from hhast.
Facebook Community Bot <[email protected]>
is used for the bot running in Meta Platforms infrastructure.
The corresponding bot email for GitHub Actions might be GitHub <[email protected]>
Or maybe we can use a mail list like Hack OSS Team <[email protected]>
?
from hhast.
Related Issues (20)
- [ Regression ] Mismatched configuration for a linter should fail the lint run HOT 2
- Suppression comments for HHClientLinter don't mesh well with /**/ comments HOT 3
- Known bad HHClientLinters need to be automatically unconditionally suppressed HOT 5
- Delete HHAST linters that duplicate good HHClientLinters HOT 6
- Support readable aliases for HHClientLinter rules HOT 4
- Linter to check if the result of the new operator is silently discarded
- Support HHAST_IGNORE_ALL for hhclientlinter codes HOT 2
- Disable some lint rules by default HOT 2
- hh_client lints are slow and unreliable in IDE HOT 1
- Overrides are not respected with recent update HOT 1
- [ RFC ] Adding an optional allow list to hhast-lint.json HOT 1
- HHAST crashes with nightly HHVM
- GitHub Actions are not triggered for the pull request to update schema
- DontSuppressLintErrorsLinter
- DontReassignParametersLinter
- DontReturnFromCloneLinter
- Remove use of the XHProf profiler
- If present `async` should be to the immediate left of `function` HOT 1
- Linter to make properties and methods only accessible through `$this`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hhast.