Fix attribution for schema update commits

[fredemmott]

Fix attribution for schema update commits

[Atry]

It seems that GitHub determines the author according to the git blame of the cron line in the Github action flow

hhast/.github/workflows/build-and-test.yml

Line 6 in 0a12574

- cron: "42 15 * * *"

See https://github.com/orgs/community/discussions/25067

[fredemmott]

Thanks; if this isn't based on the token, the easiest ways to change it would be git config --global user.name FOO and git config --global user.email FOO or the GIT_AUTHOR_*/GIT_COMMITTER_* variables at https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables , as a guess, changing them to point to facebook-github-bot

It also might end up giving you more readable results to split out the update workflow from the main testing workflow

[zpao]

Ok, it looks like @Atry is likely right. Ignoring the issues with that…

We should probably pass an explicit author in these 2 cases. Not sure if it makes sense to do that in all cases or just if it's a scheduled job. Either way, you want to pass author in the with arguments to the action being run there. cf. https://github.com/peter-evans/create-pull-request#action-inputs

• https://github.com/hhvm/hhast/blob/main/.github/workflows/build-and-test.yml#L69-L75
• https://github.com/hhvm/hhast/blob/main/.github/workflows/build-and-test.yml#L100-L108

I don't know if y'all have a bot you're using (hhvm-bot had some issues IIRC), so could just make it facebook-github-bot if you want. Facebook Community Bot <[email protected]>

[Atry]

Facebook Community Bot <[email protected]> is used for the bot running in Meta Platforms infrastructure.

The corresponding bot email for GitHub Actions might be GitHub <[email protected]>

Or maybe we can use a mail list like Hack OSS Team <[email protected]> ?