[FEATURE REQUEST] Add a function to create RedisConnOpt from a URL

[hibiken]

[FEATURE REQUEST] Add a function to create RedisConnOpt from a URL

[hibiken]

I see. Redis#ParseURL returns Options which we can use for RedisClientOpt. But we also want to support RedisFailoverClientOpt which needs FailoverOptions From the redis package. Maybe we could look at their implementations as a reference? And I suppose we could use Redis#ParseURL to handle URLs for basic cases.

[hibiken]

@rugwirobaker Thanks for opening this issue!
I think having a function to create a RedisConnOpt from a URL is valuable.

Would you mind explaining the pain points in more detail just so that I understand it better? What was annoying? I'm guessing you had access to a Redis URL and had to parse it every time you need to instantiate asynq.Client or asynq.Background?

For the specification of the function, let's create a function with this signature:

func ParseRedisURL(url string) (RedisConnOpt, error)

Note: RedisConnOpt is a union of RedisClientOpt and RedisFailoverClientOpt. The former is used connecting directly to Redis and the latter is used to connecting to Redis using Sentinel.

For the URL scheme I found this page (let's follow this scheme to support different mode)

I'm excited to get contributions from the community, so please feel free to open a PR!

[rugwirobaker]

Hey, I have noticed that the redis client you are using already has it's own parser. Wouldn't be a good idea to just use that and build from there?

[hibiken]

@rugwirobaker I'm assigning this issue to you for now, but feel free to assign it back to me if you don't have enough bandwidth to work on this in the next few weeks 👍