Comments (11)
Your "Erasing device ..." is about the behavior of the API, the SDK has such a way to disconnect from the AP, and the STA mode is maintained because AutoConnect disconnects from the current AP, it is "Disconnect".
Also, "Reset..." calls ESP.reset() is a hard reset and can leave some of the registers in the old state, ESP.restart() tells the SDK to reboot, so its a more clean reboot. Both behaviors are different.
So, what's this issue? only label description?
from autoconnect.
yes, it is more a label description, but that is my opnion :)
from autoconnect.
Basically, I agree with your opinion. It is important for UI design. However, I would like to prioritize differences in behavior according to the specification of SDK for this label.
from autoconnect.
maybe at a later state, you could make the label as a variabel so one could change like other config item's
for now, let's work on a stable new release 👍
from autoconnect.
Maybew the labels could be placed in a separate file, so people can localize the labels
from autoconnect.
So, the label will be determined by the separate file like as define macros contained in the user sketch folder at build timing. And If the file does not exist, the label will assume the defaults. right?
I basically adopt your idea, but it may be difficult to implement due to Arduino IDE build limitations.
Well, I start the study. You can confirm the status with the project.
from autoconnect.
@ageurtse We will have no choice but to lower the goal standard, I think.
Initially, I considered overwriting the menu string by individually putting only the label definition file in each sketch folder and aimed to adopt the AutoConnect defaults if there is no separate label definition file.
It is rationally to change the label string at build time because scenes that necessity rewriting labels during sketch executing are very rare.
However, this strategy is unlikely to be realized. I reviewed the c++ grammar to avoid conflicts between a separate file and AutoConnect initial values, but I can not find a way to work. It is possible if I intervene in Arduino's build mechanism, but that would be impossible. (Of course, lack of my knowledge might be factors)
So I would like to propose to you the followings:
-
The label definition file is only one in AutoConnect library
It is the simplest solution. The definition file is namedAutoConnectLabels.h
and will placed in theArduio/library/AutoConnect/src
folder. You can change the label string with the AutoConnectLabels.h but it will influence all sketches. If you want to change the label for each sketch, you need to change the distribution file of the AutoConnect library every time you build. -
Enhance AutoConnectConfig to replace the labels
Make the labels specified by AutoConnectConfig. The labels specified with AutoConnectConfig overrides the default at sketch execution time.
I don't like this solution so much.
How about your opinion?
from autoconnect.
didn't know i could change it in that file.
I didn't look in there, that is for me the right location.
Thanks, for me it could be closed.
from autoconnect.
AutoConnectLabels.h not separated yet. It will be for v0.9.8.
If you agree with the solution by AutoConnectLabels.h, it will be the implementation with v0.9.8. OK?
from autoconnect.
Hello @ageurtse, I staged up the supports AutoConnectLabels.h to the development branch for v 0.9.8.
You can try now. If some problem you find, please let me know.
from autoconnect.
Merged #57
from autoconnect.
Related Issues (20)
- AutoConnect to offer captive portal for 5min even if ESP32 is WiFi-Connected HOT 1
- AutoConnect on WiFi connection error shows too many redirects. HOT 2
- AutoConnectCore Not Working HOT 1
- Failing to store network HOT 2
- AutoConnect not longer runningh on ESP8266 HOT 2
- Use Autoconnect library with ESP now HOT 1
- Issue after updating libraries in my PIO project: enableCors() HOT 2
- Strange Issue
- WiFiClientSecure is not working with AutoConnect HOT 1
- how to use esp8266 with WiFiClientSecure
- AutoConnectPageImpl.hpp:1001:20: error: there are no arguments to 'spi_flash_get_chip_size' that depend on a template parameter, so a declaration of 'spi_flash_get_chip_size' must be available [-fpermissive] HOT 2
- Save data from Custom Page to flash HOT 2
- esp32: frozen loop() and kicked out of the WiFi connection at Configure new AP
- WPA2 Enterprise support
- Captive portal cause watchdog triggering
- Possibility to change pass for SoftAP from webui.
- Fresh Install and even the simplest of code will not compile HOT 2
- Unable to select file in fw update page using ios device, android and desktop works.
- Wifi credencials
- Need update to SpiRamAllocatorST for ArduinoJson version 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autoconnect.