Giter Site home page Giter Site logo

Comments (2)

PaulRBerg avatar PaulRBerg commented on June 15, 2024 1

You're right, the cost is not worth the benefit. I think at the time of opening this issue, the ABIs were distributed as JSON files as well. But in the meantime, we switched to TypeChain factories only.

I'll close this for now. If the maintenance cost becomes so high in this repository that automating the ABIs would be worth it, we'll re-examine this issue then.

from hifi-subgraph.

scorpion9979 avatar scorpion9979 commented on June 15, 2024

@PaulRBerg I just noticed that this issue would be a bit tricky to tackle as subgraph.yaml expects the ABIs to be json files, while our npm repos only expose the ABIs as part of the generated Typechain contract factories. I believe a solution to this would need to implement a script to pull the ABIs from those contract factories and place them into their own separate json files in a git-ignored directory, but I don't think the cost-benefit would be high enough to warrant that change.

from hifi-subgraph.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.